qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Brad Hards <bradh@frogmouth.net>
To: qemu-devel@nongnu.org
Cc: Alon Levy <alevy@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 4/4] qxl: allow QXL_IO_LOG also in vga
Date: Sun, 10 Apr 2011 21:37:12 +1000	[thread overview]
Message-ID: <201104102137.13005.bradh@frogmouth.net> (raw)
In-Reply-To: <1302431166-17771-5-git-send-email-alevy@redhat.com>

On Sun, 10 Apr 2011 08:26:06 pm Alon Levy wrote:
> -        if (d->mode == QXL_MODE_NATIVE || d->mode == QXL_MODE_COMPAT)
> +        if (d->mode == QXL_MODE_NATIVE || d->mode == QXL_MODE_COMPAT
> +            || (io_port == QXL_IO_LOG))
I think this might look better with consistent use of brackets.

Low priority, for your consideration.

Brad

  reply	other threads:[~2011-04-10 11:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-10 10:26 [Qemu-devel] [PATCH 0/4] qxl: debug related fixes Alon Levy
2011-04-10 10:26 ` [Qemu-devel] [PATCH 1/4] qxl: interface_get_command: fix reported mode Alon Levy
2011-04-10 10:26 ` [Qemu-devel] [PATCH 2/4] qxl: add mode to debugprint on destroy primary Alon Levy
2011-04-10 10:26 ` [Qemu-devel] [PATCH 3/4] qxl: add debug_cs and cmdlog_cs Alon Levy
2011-04-10 10:26 ` [Qemu-devel] [PATCH 4/4] qxl: allow QXL_IO_LOG also in vga Alon Levy
2011-04-10 11:37   ` Brad Hards [this message]
2011-04-10 11:48     ` Alon Levy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201104102137.13005.bradh@frogmouth.net \
    --to=bradh@frogmouth.net \
    --cc=alevy@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).