From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=48824 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q8sxE-0006s8-4X
	for qemu-devel@nongnu.org; Sun, 10 Apr 2011 07:37:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bradh@frogmouth.net>) id 1Q8sxD-0006Ec-Bv
	for qemu-devel@nongnu.org; Sun, 10 Apr 2011 07:37:19 -0400
Received: from ipmail05.adl6.internode.on.net ([150.101.137.143]:63361)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bradh@frogmouth.net>) id 1Q8sxD-0006E1-1V
	for qemu-devel@nongnu.org; Sun, 10 Apr 2011 07:37:19 -0400
From: Brad Hards <bradh@frogmouth.net>
Subject: Re: [Qemu-devel] [PATCH 4/4] qxl: allow QXL_IO_LOG also in vga
Date: Sun, 10 Apr 2011 21:37:12 +1000
References: <1302431166-17771-1-git-send-email-alevy@redhat.com>
	<1302431166-17771-5-git-send-email-alevy@redhat.com>
In-Reply-To: <1302431166-17771-5-git-send-email-alevy@redhat.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201104102137.13005.bradh@frogmouth.net>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Alon Levy <alevy@redhat.com>

On Sun, 10 Apr 2011 08:26:06 pm Alon Levy wrote:
> -        if (d->mode == QXL_MODE_NATIVE || d->mode == QXL_MODE_COMPAT)
> +        if (d->mode == QXL_MODE_NATIVE || d->mode == QXL_MODE_COMPAT
> +            || (io_port == QXL_IO_LOG))
I think this might look better with consistent use of brackets.

Low priority, for your consideration.

Brad