From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=35988 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q98lt-0000as-Ja
	for qemu-devel@nongnu.org; Mon, 11 Apr 2011 00:30:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dgibson@ozlabs.org>) id 1Q98lr-0006Kl-8V
	for qemu-devel@nongnu.org; Mon, 11 Apr 2011 00:30:41 -0400
Received: from ozlabs.org ([203.10.76.45]:56113)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgibson@ozlabs.org>) id 1Q98lq-0006JU-QN
	for qemu-devel@nongnu.org; Mon, 11 Apr 2011 00:30:39 -0400
Date: Mon, 11 Apr 2011 14:30:28 +1000
From: David Gibson <david@gibson.dropbear.id.au>
Message-ID: <20110411043028.GN3151@yookeroo>
References: <BANLkTimM42+rbZLG3zioZ0XNfahy=aGHeA@mail.gmail.com>
	<B67107F9-BA40-436F-9659-72B91FDAA62A@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <B67107F9-BA40-436F-9659-72B91FDAA62A@suse.de>
Subject: [Qemu-devel] Re: [PATCH] ppc: remove a write-only variable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel <qemu-devel@nongnu.org>

On Sat, Apr 09, 2011 at 05:28:06PM +0200, Alexander Graf wrote:
> 
> 
> 
> 
> Am 09.04.2011 um 16:56 schrieb Blue Swirl <blauwirbel@gmail.com>:
> 
> > Remove a write-only variable, spotted by GCC 4.6.0:
> > /src/qemu/hw/ppc.c: In function 'power7_set_irq':
> > /src/qemu/hw/ppc.c:255:9: error: variable 'cur_level' set but not used
> > [-Werror=unused-but-set-variable]
> > 
> > Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
> > ---
> > hw/ppc.c |    2 --
> > 1 files changed, 0 insertions(+), 2 deletions(-)
> > 
> > diff --git a/hw/ppc.c b/hw/ppc.c
> > index dabb816..1873328 100644
> > --- a/hw/ppc.c
> > +++ b/hw/ppc.c
> > @@ -252,11 +252,9 @@ void ppc970_irq_init (CPUState *env)
> > static void power7_set_irq (void *opaque, int pin, int level)
> > {
> >     CPUState *env = opaque;
> > -    int cur_level;
> > 
> >     LOG_IRQ("%s: env %p pin %d level %d\n", __func__,
> >                 env, pin, level);
> > -    cur_level = (env->irq_input_state >> pin) & 1;
> 
> David, Ben?

That should be fine.  It's a hang over from the ppc970 code which I
adapted.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson