* [Qemu-devel] [PATCH] ppc: remove a write-only variable
@ 2011-04-09 14:56 Blue Swirl
2011-04-09 15:28 ` [Qemu-devel] " Alexander Graf
0 siblings, 1 reply; 5+ messages in thread
From: Blue Swirl @ 2011-04-09 14:56 UTC (permalink / raw)
To: qemu-devel, Alexander Graf
Remove a write-only variable, spotted by GCC 4.6.0:
/src/qemu/hw/ppc.c: In function 'power7_set_irq':
/src/qemu/hw/ppc.c:255:9: error: variable 'cur_level' set but not used
[-Werror=unused-but-set-variable]
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
---
hw/ppc.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/hw/ppc.c b/hw/ppc.c
index dabb816..1873328 100644
--- a/hw/ppc.c
+++ b/hw/ppc.c
@@ -252,11 +252,9 @@ void ppc970_irq_init (CPUState *env)
static void power7_set_irq (void *opaque, int pin, int level)
{
CPUState *env = opaque;
- int cur_level;
LOG_IRQ("%s: env %p pin %d level %d\n", __func__,
env, pin, level);
- cur_level = (env->irq_input_state >> pin) & 1;
switch (pin) {
case POWER7_INPUT_INT:
--
1.7.2.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Qemu-devel] Re: [PATCH] ppc: remove a write-only variable
2011-04-09 14:56 [Qemu-devel] [PATCH] ppc: remove a write-only variable Blue Swirl
@ 2011-04-09 15:28 ` Alexander Graf
2011-04-11 4:30 ` David Gibson
0 siblings, 1 reply; 5+ messages in thread
From: Alexander Graf @ 2011-04-09 15:28 UTC (permalink / raw)
To: Blue Swirl; +Cc: qemu-devel, David Gibson
Am 09.04.2011 um 16:56 schrieb Blue Swirl <blauwirbel@gmail.com>:
> Remove a write-only variable, spotted by GCC 4.6.0:
> /src/qemu/hw/ppc.c: In function 'power7_set_irq':
> /src/qemu/hw/ppc.c:255:9: error: variable 'cur_level' set but not used
> [-Werror=unused-but-set-variable]
>
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
> ---
> hw/ppc.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/hw/ppc.c b/hw/ppc.c
> index dabb816..1873328 100644
> --- a/hw/ppc.c
> +++ b/hw/ppc.c
> @@ -252,11 +252,9 @@ void ppc970_irq_init (CPUState *env)
> static void power7_set_irq (void *opaque, int pin, int level)
> {
> CPUState *env = opaque;
> - int cur_level;
>
> LOG_IRQ("%s: env %p pin %d level %d\n", __func__,
> env, pin, level);
> - cur_level = (env->irq_input_state >> pin) & 1;
David, Ben?
Alex
>
^ permalink raw reply [flat|nested] 5+ messages in thread* [Qemu-devel] Re: [PATCH] ppc: remove a write-only variable
2011-04-09 15:28 ` [Qemu-devel] " Alexander Graf
@ 2011-04-11 4:30 ` David Gibson
2011-04-11 7:48 ` Alexander Graf
0 siblings, 1 reply; 5+ messages in thread
From: David Gibson @ 2011-04-11 4:30 UTC (permalink / raw)
To: Alexander Graf; +Cc: Blue Swirl, qemu-devel
On Sat, Apr 09, 2011 at 05:28:06PM +0200, Alexander Graf wrote:
>
>
>
>
> Am 09.04.2011 um 16:56 schrieb Blue Swirl <blauwirbel@gmail.com>:
>
> > Remove a write-only variable, spotted by GCC 4.6.0:
> > /src/qemu/hw/ppc.c: In function 'power7_set_irq':
> > /src/qemu/hw/ppc.c:255:9: error: variable 'cur_level' set but not used
> > [-Werror=unused-but-set-variable]
> >
> > Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
> > ---
> > hw/ppc.c | 2 --
> > 1 files changed, 0 insertions(+), 2 deletions(-)
> >
> > diff --git a/hw/ppc.c b/hw/ppc.c
> > index dabb816..1873328 100644
> > --- a/hw/ppc.c
> > +++ b/hw/ppc.c
> > @@ -252,11 +252,9 @@ void ppc970_irq_init (CPUState *env)
> > static void power7_set_irq (void *opaque, int pin, int level)
> > {
> > CPUState *env = opaque;
> > - int cur_level;
> >
> > LOG_IRQ("%s: env %p pin %d level %d\n", __func__,
> > env, pin, level);
> > - cur_level = (env->irq_input_state >> pin) & 1;
>
> David, Ben?
That should be fine. It's a hang over from the ppc970 code which I
adapted.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
^ permalink raw reply [flat|nested] 5+ messages in thread* [Qemu-devel] Re: [PATCH] ppc: remove a write-only variable
2011-04-11 4:30 ` David Gibson
@ 2011-04-11 7:48 ` Alexander Graf
2011-04-11 17:25 ` [Qemu-devel] " Blue Swirl
0 siblings, 1 reply; 5+ messages in thread
From: Alexander Graf @ 2011-04-11 7:48 UTC (permalink / raw)
To: David Gibson; +Cc: Blue Swirl, QEMU-devel Developers, Stefan Hajnoczi
On 11.04.2011, at 06:30, David Gibson wrote:
> On Sat, Apr 09, 2011 at 05:28:06PM +0200, Alexander Graf wrote:
>>
>>
>>
>>
>> Am 09.04.2011 um 16:56 schrieb Blue Swirl <blauwirbel@gmail.com>:
>>
>>> Remove a write-only variable, spotted by GCC 4.6.0:
>>> /src/qemu/hw/ppc.c: In function 'power7_set_irq':
>>> /src/qemu/hw/ppc.c:255:9: error: variable 'cur_level' set but not used
>>> [-Werror=unused-but-set-variable]
>>>
>>> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
>>> ---
>>> hw/ppc.c | 2 --
>>> 1 files changed, 0 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/hw/ppc.c b/hw/ppc.c
>>> index dabb816..1873328 100644
>>> --- a/hw/ppc.c
>>> +++ b/hw/ppc.c
>>> @@ -252,11 +252,9 @@ void ppc970_irq_init (CPUState *env)
>>> static void power7_set_irq (void *opaque, int pin, int level)
>>> {
>>> CPUState *env = opaque;
>>> - int cur_level;
>>>
>>> LOG_IRQ("%s: env %p pin %d level %d\n", __func__,
>>> env, pin, level);
>>> - cur_level = (env->irq_input_state >> pin) & 1;
>>
>> David, Ben?
>
> That should be fine. It's a hang over from the ppc970 code which I
> adapted.
Alright.
Acked-by: Alexander Graf <agraf@suse.de>
Blue, mind to apply it directly? That's easier than going through my tree.
Alex
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] ppc: remove a write-only variable
2011-04-11 7:48 ` Alexander Graf
@ 2011-04-11 17:25 ` Blue Swirl
0 siblings, 0 replies; 5+ messages in thread
From: Blue Swirl @ 2011-04-11 17:25 UTC (permalink / raw)
To: Alexander Graf; +Cc: QEMU-devel Developers, Stefan Hajnoczi, David Gibson
On Mon, Apr 11, 2011 at 10:48 AM, Alexander Graf <agraf@suse.de> wrote:
>
> On 11.04.2011, at 06:30, David Gibson wrote:
>
>> On Sat, Apr 09, 2011 at 05:28:06PM +0200, Alexander Graf wrote:
>>>
>>>
>>>
>>>
>>> Am 09.04.2011 um 16:56 schrieb Blue Swirl <blauwirbel@gmail.com>:
>>>
>>>> Remove a write-only variable, spotted by GCC 4.6.0:
>>>> /src/qemu/hw/ppc.c: In function 'power7_set_irq':
>>>> /src/qemu/hw/ppc.c:255:9: error: variable 'cur_level' set but not used
>>>> [-Werror=unused-but-set-variable]
>>>>
>>>> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
>>>> ---
>>>> hw/ppc.c | 2 --
>>>> 1 files changed, 0 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/hw/ppc.c b/hw/ppc.c
>>>> index dabb816..1873328 100644
>>>> --- a/hw/ppc.c
>>>> +++ b/hw/ppc.c
>>>> @@ -252,11 +252,9 @@ void ppc970_irq_init (CPUState *env)
>>>> static void power7_set_irq (void *opaque, int pin, int level)
>>>> {
>>>> CPUState *env = opaque;
>>>> - int cur_level;
>>>>
>>>> LOG_IRQ("%s: env %p pin %d level %d\n", __func__,
>>>> env, pin, level);
>>>> - cur_level = (env->irq_input_state >> pin) & 1;
>>>
>>> David, Ben?
>>
>> That should be fine. It's a hang over from the ppc970 code which I
>> adapted.
>
> Alright.
>
> Acked-by: Alexander Graf <agraf@suse.de>
>
> Blue, mind to apply it directly? That's easier than going through my tree.
Thanks for the ack, applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-04-12 1:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-09 14:56 [Qemu-devel] [PATCH] ppc: remove a write-only variable Blue Swirl
2011-04-09 15:28 ` [Qemu-devel] " Alexander Graf
2011-04-11 4:30 ` David Gibson
2011-04-11 7:48 ` Alexander Graf
2011-04-11 17:25 ` [Qemu-devel] " Blue Swirl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).