From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=44610 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q9ARy-0001rk-R4
	for qemu-devel@nongnu.org; Mon, 11 Apr 2011 02:18:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1Q9ARx-00059N-OS
	for qemu-devel@nongnu.org; Mon, 11 Apr 2011 02:18:14 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55395)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1Q9ARx-000598-G5
	for qemu-devel@nongnu.org; Mon, 11 Apr 2011 02:18:13 -0400
Date: Mon, 11 Apr 2011 11:48:09 +0530
From: Amit Shah <amit.shah@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/5] atapi: Implement 'media' subcommand for
	GESN
Message-ID: <20110411061809.GB7523@amit-x200.redhat.com>
References: <cover.1302246567.git.amit.shah@redhat.com>
	<m3zko1m69d.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m3zko1m69d.fsf@blackfin.pond.sub.org>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, qemu list <qemu-devel@nongnu.org>, Juan Quintela <quintela@redhat.com>

On (Fri) 08 Apr 2011 [11:39:26], Markus Armbruster wrote:
> Results of quick test run now, patch review to follow.
> 
> Test uses a simple program to try ioctl CDROM_DRIVE_STATUS (attached).

...

> Test in guest without your patches:
> 
>     [start with empty drive]
>     # ./drive-status 
>     CDS_NO_DISC
>     # eject /dev/sr0
>     # ./drive-status 
>     CDS_NO_DISC
>     [incorrect, should be CDS_TRAY_OPEN]
>     # eject -t /dev/sr0
>     # ./drive-status 
>     CDS_NO_DISC
>     [insert media with monitor command change]
>     # ./drive-status 
>     CDS_DISC_OK
>     # eject /dev/sr0
>     # ./drive-status 
>     CDS_NO_DISC
>     [incorrect, should be CDS_TRAY_OPEN]
>     # eject -t /dev/sr0
>     # ./drive-status 
>     CDS_DISC_OK
> 
> With the patches, it behaves as expected.  Except something (guest
> kernel?) closes the tray right after eject if there's a medium in the
> open tray.

Can you try with the two patches I sent on Saturday:

atapi: Drives can be locked without media present
atapi: Report correct errors on guest eject request

Thanks,
		Amit