From: Stefan Hajnoczi <stefanha@gmail.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Ryan Harper <ryanh@us.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>,
Christoph Hellwig <hch@lst.de>
Subject: [Qemu-devel] Re: To O_EXCL or not to O_EXCL open host_cdrom
Date: Mon, 11 Apr 2011 09:31:43 +0100 [thread overview]
Message-ID: <20110411083143.GA22987@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <20110411050732.GA7523@amit-x200.redhat.com>
On Mon, Apr 11, 2011 at 10:37:32AM +0530, Amit Shah wrote:
> On (Fri) 08 Apr 2011 [12:33:27], Stefan Hajnoczi wrote:
> > The other concern I have about using O_EXCL is that we expose
> > ourselves to race conditions if there is ever a need to re-open the
> > device. When QEMU closes its file descriptor another program may be
> > scheduled to run and open the device with O_EXCL. Now QEMU will not
> > be able to open the CD-ROM anymore.
>
> The admins should really be the ones worrying about this, not QEMU.
Think of a desktop use case. virt-manager lets me pass through the host
CD-ROM today. Desktops have hald/udisks and you can't expect users to
disable/reenable those services just for QEMU.
Stefan
next prev parent reply other threads:[~2011-04-11 8:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-08 11:33 [Qemu-devel] To O_EXCL or not to O_EXCL open host_cdrom Stefan Hajnoczi
2011-04-11 5:07 ` [Qemu-devel] " Amit Shah
2011-04-11 8:31 ` Stefan Hajnoczi [this message]
2011-04-11 13:30 ` Avi Kivity
2011-04-11 13:27 ` [Qemu-devel] " Avi Kivity
2011-04-11 18:19 ` Christoph Hellwig
2011-04-12 7:52 ` Daniel P. Berrange
2011-04-12 8:10 ` Kevin Wolf
2011-04-12 8:19 ` Daniel P. Berrange
2011-04-12 9:14 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110411083143.GA22987@stefanha-thinkpad.localdomain \
--to=stefanha@gmail.com \
--cc=amit.shah@redhat.com \
--cc=armbru@redhat.com \
--cc=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=ryanh@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).