From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:45780)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1Q9V7L-0002Vr-Um
	for qemu-devel@nongnu.org; Tue, 12 Apr 2011 00:22:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1Q9V7L-00046W-3n
	for qemu-devel@nongnu.org; Tue, 12 Apr 2011 00:22:19 -0400
Received: from mx1.redhat.com ([209.132.183.28]:52442)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1Q9V7K-00046Q-RM
	for qemu-devel@nongnu.org; Tue, 12 Apr 2011 00:22:19 -0400
Date: Tue, 12 Apr 2011 09:52:13 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20110412042213.GA26678@amit-x200.redhat.com>
References: <cover.1302246567.git.amit.shah@redhat.com>
	<m3zko1m69d.fsf@blackfin.pond.sub.org>
	<20110411061809.GB7523@amit-x200.redhat.com>
	<m362qklx3a.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m362qklx3a.fsf@blackfin.pond.sub.org>
Subject: Re: [Qemu-devel] [PATCH 0/5] atapi: Implement 'media' subcommand
 for GESN
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <http://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, Juan Quintela <quintela@redhat.com>, qemu list <qemu-devel@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>

On (Mon) 11 Apr 2011 [15:46:33], Markus Armbruster wrote:
> Amit Shah <amit.shah@redhat.com> writes:
> 
> > On (Fri) 08 Apr 2011 [11:39:26], Markus Armbruster wrote:
> >> Results of quick test run now, patch review to follow.
> >> 
> >> Test uses a simple program to try ioctl CDROM_DRIVE_STATUS (attached).
> >
> > ...
> >
> >> Test in guest without your patches:
> >> 
> >>     [start with empty drive]
> >>     # ./drive-status 
> >>     CDS_NO_DISC
> >>     # eject /dev/sr0
> >>     # ./drive-status 
> >>     CDS_NO_DISC
> >>     [incorrect, should be CDS_TRAY_OPEN]
> >>     # eject -t /dev/sr0
> >>     # ./drive-status 
> >>     CDS_NO_DISC
> >>     [insert media with monitor command change]
> >>     # ./drive-status 
> >>     CDS_DISC_OK
> >>     # eject /dev/sr0
> >>     # ./drive-status 
> >>     CDS_NO_DISC
> >>     [incorrect, should be CDS_TRAY_OPEN]
> >>     # eject -t /dev/sr0
> >>     # ./drive-status 
> >>     CDS_DISC_OK
> >> 
> >> With the patches, it behaves as expected.  Except something (guest
> >> kernel?) closes the tray right after eject if there's a medium in the
> >> open tray.
> >
> > Can you try with the two patches I sent on Saturday:
> >
> > atapi: Drives can be locked without media present
> > atapi: Report correct errors on guest eject request
> 
> My test cases show no further improvement.

OK - thanks for testing!

		Amit