From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:41279)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <yamahata@valinux.co.jp>) id 1Q9ZHM-00082y-C9
	for qemu-devel@nongnu.org; Tue, 12 Apr 2011 04:48:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <yamahata@valinux.co.jp>) id 1Q9ZHK-0000Sh-Vu
	for qemu-devel@nongnu.org; Tue, 12 Apr 2011 04:48:56 -0400
Received: from mail.valinux.co.jp ([210.128.90.3]:60607)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <yamahata@valinux.co.jp>) id 1Q9ZHK-0000RE-M8
	for qemu-devel@nongnu.org; Tue, 12 Apr 2011 04:48:54 -0400
Date: Tue, 12 Apr 2011 17:48:50 +0900
From: Isaku Yamahata <yamahata@valinux.co.jp>
Message-ID: <20110412084850.GD30075@valinux.co.jp>
References: <4DA3DF6B.8010308@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4DA3DF6B.8010308@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH] fix acpi regression
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <http://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wen Congyang <wency@cn.fujitsu.com>
Cc: blauwirbel@gmail.com, qemu-devel <qemu-devel@nongnu.org>, Aurelien Jarno <aurelien@aurel32.net>

On Tue, Apr 12, 2011 at 01:13:15PM +0800, Wen Congyang wrote:
> This bug is introduced by commit 23910d3f.

Oh, Thanks. Good catch. I agree with the first hunk.
But what is the second hunk for? The GPE STS register is W1C.
(NULL check and 0xff masking is okay. it's a bit redundant, though)

>>From ACPI4 spec 4.7.4.1.1.
can only be cleared by software writing a "1" to its respective bit position.

thanks,

> 
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> 
> ---
>  hw/acpi.c |   10 +++-------
>  1 files changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/hw/acpi.c b/hw/acpi.c
> index e372474..790bd3b 100644
> --- a/hw/acpi.c
> +++ b/hw/acpi.c
> @@ -355,7 +355,7 @@ static uint8_t *acpi_gpe_ioport_get_ptr(ACPIGPE *gpe, uint32_t addr)
>      if (addr < gpe->len / 2) {
>          cur = gpe->sts + addr;
>      } else if (addr < gpe->len) {
> -        cur = gpe->en + addr;
> +        cur = gpe->en + addr - gpe->len / 2;
>      } else {
>          abort();
>      }
> @@ -369,12 +369,8 @@ void acpi_gpe_ioport_writeb(ACPIGPE *gpe, uint32_t addr, uint32_t val)
>  
>      addr -= gpe->blk;
>      cur = acpi_gpe_ioport_get_ptr(gpe, addr);
> -    if (addr < gpe->len / 2) {
> -        /* GPE_STS */
> -        *cur = (*cur) & ~val;
> -    } else if (addr < gpe->len) {
> -        /* GPE_EN */
> -        *cur = val;
> +    if (cur != NULL) {
> +        *cur = val & 0xff;
>      } else {
>          abort();
>      }
> -- 
> 1.7.1
> 
-- 
yamahata