From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:46282)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1Q9e8i-0006of-47
	for qemu-devel@nongnu.org; Tue, 12 Apr 2011 10:00:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1Q9e8h-0002Ni-91
	for qemu-devel@nongnu.org; Tue, 12 Apr 2011 10:00:20 -0400
Received: from mx1.redhat.com ([209.132.183.28]:20478)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1Q9e8g-0002NV-Or
	for qemu-devel@nongnu.org; Tue, 12 Apr 2011 10:00:19 -0400
Date: Tue, 12 Apr 2011 19:30:13 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20110412140013.GB13631@amit-x200.redhat.com>
References: <cover.1302608369.git.amit.shah@redhat.com>
	<cover.1302608369.git.amit.shah@redhat.com>
	<bd2eb21cec6c08d25c75bb16b91a6056a10c6ec6.1302608369.git.amit.shah@redhat.com>
	<m3ei57y5rk.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <m3ei57y5rk.fsf@blackfin.pond.sub.org>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3 3/5] atapi: GESN: Use structs for
 commonly-used field types
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <http://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, qemu list <qemu-devel@nongnu.org>, Juan Quintela <quintela@redhat.com>

On (Tue) 12 Apr 2011 [15:10:39], Markus Armbruster wrote:
> Amit Shah <amit.shah@redhat.com> writes:
>=20
> > Instead of using magic numbers, use structs that are more descriptive=
 of
> > the fields being used.
> >
> > Signed-off-by: Amit Shah <amit.shah@redhat.com>
> > ---
> >  hw/ide/core.c |   22 +++++++++++++++++-----
> >  1 files changed, 17 insertions(+), 5 deletions(-)
> >
> > diff --git a/hw/ide/core.c b/hw/ide/core.c
> > index 5b64676..e838990 100644
> > --- a/hw/ide/core.c
> > +++ b/hw/ide/core.c
> > @@ -1088,11 +1088,23 @@ static void handle_get_event_status_notificat=
ion(IDEState *s,
> >                                                   uint8_t *buf,
> >                                                   const uint8_t *pack=
et)
> >  {
> > -    unsigned int max_len;
> > -
> > -    max_len =3D ube16_to_cpu(packet + 7);
> > -
> > -    if (!(packet[1] & 0x01)) { /* asynchronous mode */
> > +    struct {
> > +        uint8_t opcode;
> > +        uint8_t polled;        /* lsb bit is polled; others are rese=
rved */
> > +        uint8_t reserved2[2];
> > +        uint8_t class;
> > +        uint8_t reserved3[2];
> > +        uint16_t len;
> > +        uint8_t control;
> > +    } __attribute__((packed)) *gesn_cdb;
> > +
> > +    unsigned int max_len, used_len;
>=20
> .../hw/ide/core.c:1250: warning: unused variable =E2=80=98used_len=E2=80=
=99

OK, it should come with 4/5.

Bad rebase day.

		Amit