From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:44073) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q9eKU-0006aa-2e for qemu-devel@nongnu.org; Tue, 12 Apr 2011 10:12:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q9eKS-00055v-4K for qemu-devel@nongnu.org; Tue, 12 Apr 2011 10:12:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42040) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q9eKR-00055m-Py for qemu-devel@nongnu.org; Tue, 12 Apr 2011 10:12:28 -0400 Date: Tue, 12 Apr 2011 19:42:22 +0530 From: Amit Shah Message-ID: <20110412141222.GC13631@amit-x200.redhat.com> References: <2170ea9881efc68cd2265b9df956a30eb689b8cc.1302608369.git.amit.shah@redhat.com> <4DA44F0D.2020506@redhat.com> <20110412135913.GA13631@amit-x200.redhat.com> <4DA45C9B.9040904@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4DA45C9B.9040904@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 4/5] atapi: GESN: Standardise event response handling for future additions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Juan Quintela , Stefan Hajnoczi , Markus Armbruster , qemu list , Paolo Bonzini On (Tue) 12 Apr 2011 [16:07:23], Kevin Wolf wrote: > Am 12.04.2011 15:59, schrieb Amit Shah: > > On (Tue) 12 Apr 2011 [15:09:33], Kevin Wolf wrote: > >> Am 12.04.2011 13:43, schrieb Amit Shah: > >>> Handle GET_EVENT_STATUS_NOTIFICATION's No Event Available response in a > >>> generic way so that future additions to the code to handle other > >>> response types is easier. > >>> > >>> Signed-off-by: Amit Shah > >>> --- > >>> hw/ide/core.c | 24 +++++++++++++++++++----- > >>> 1 files changed, 19 insertions(+), 5 deletions(-) > >>> > >>> diff --git a/hw/ide/core.c b/hw/ide/core.c > >>> index e838990..a9bc1e3 100644 > >>> --- a/hw/ide/core.c > >>> +++ b/hw/ide/core.c > >>> @@ -1098,9 +1098,17 @@ static void handle_get_event_status_notification(IDEState *s, > >>> uint8_t control; > >>> } __attribute__((packed)) *gesn_cdb; > >>> > >>> + struct { > >>> + uint16_t len; > >>> + uint8_t notification_class; > >>> + uint8_t supported_events; > >>> + } __attribute((packed)) *gesn_event_header; > >>> + > >>> unsigned int max_len, used_len; > >>> > >>> gesn_cdb = (void *)packet; > >>> + gesn_event_header = (void *)packet; > >> > >> I think this should be buf, not packet. > > > > Ah, right. (Though they're the same.) > > Oh, you're right. I wasn't even aware of that. At some point we should > clean this up, it's an invitation for bugs... It is. Actually it's surprising gcc didn't tell me that casting from const uint8_t * to void * and then writing to the pointer is not a good idea. Amit