From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47022) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QA4XN-0005go-5g for qemu-devel@nongnu.org; Wed, 13 Apr 2011 14:11:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QA4XM-0002DA-4K for qemu-devel@nongnu.org; Wed, 13 Apr 2011 14:11:33 -0400 Received: from hall.aurel32.net ([88.191.126.93]:43067) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QA4XL-0002Cx-Vx for qemu-devel@nongnu.org; Wed, 13 Apr 2011 14:11:32 -0400 Date: Wed, 13 Apr 2011 20:11:29 +0200 From: Aurelien Jarno Message-ID: <20110413181129.GA31081@volta.aurel32.net> References: <1302645571-20500-1-git-send-email-aurelien@aurel32.net> <1302645571-20500-16-git-send-email-aurelien@aurel32.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 15/19] target-arm: fix wrong usage of floatx80_eq_quiet() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org On Tue, Apr 12, 2011 at 11:41:49PM +0100, Peter Maydell wrote: > On 12 April 2011 22:59, Aurelien Jarno wrote: > > I haven't look at the documentation, but for the neighbouring code it looks > > clear that floatx80_eq() should be used instead of floatx80_eq_quiet(). > > Actually I think it's irrelevant -- PerformComparisonOperation() > is called only once, and the code before it carefully checks for > any NaNs and takes a different code path in that case (jumping > to the 'unordered' label). So it doesn't matter which function > we use here. I don't particularly object if you think using the > non _quiet one is aesthetically tidier. (The nwfpe code is all > hovering on the edge of total obsolescence anyhow; I certainly > don't have any test cases for it.) > Ok, I will simply drop it then. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net