From: Aurelien Jarno <aurelien@aurel32.net>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Lluís <xscript@gmx.net>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/4] [arm] trivial whitespace/indentation fixes
Date: Wed, 13 Apr 2011 20:34:32 +0200 [thread overview]
Message-ID: <20110413183432.GA6142@volta.aurel32.net> (raw)
In-Reply-To: <BANLkTi=n5Js-3LMfJ_rHzKCkRPX198BpqQ@mail.gmail.com>
On Wed, Apr 13, 2011 at 06:16:55PM +0100, Peter Maydell wrote:
> On 13 April 2011 17:38, Lluís <xscript@gmx.net> wrote:
> > Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
> > ---
> > target-arm/helper.c | 246 ++++++++++++++++++++++----------------------
> > target-arm/iwmmxt_helper.c | 28 +++--
> > target-arm/translate.c | 26 ++---
> > 3 files changed, 150 insertions(+), 150 deletions(-)
>
> My preference is not to do large-scale whitespace changes
> unless the code's being touched in that area anyway, so
> I'd prefer this not to be applied.
>
> (They make things painful for forks and branches, and
> they make git blame less useful; disadvantages outweigh
> the minor benefits of the cleanup IMHO.)
>
I agree that this patch should not be applied.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
next prev parent reply other threads:[~2011-04-13 18:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-13 16:38 [Qemu-devel] [PATCH 1/4] [arm] trivial whitespace/indentation fixes Lluís
2011-04-13 16:38 ` [Qemu-devel] [PATCH 2/4] [arm] move helpers.h to helper.h Lluís
2011-04-18 19:18 ` Aurelien Jarno
2011-04-13 16:38 ` [Qemu-devel] [PATCH 3/4] [m68k] trivial whitespace/indentation fixes Lluís
2011-04-13 16:38 ` [Qemu-devel] [PATCH 4/4] [m68k] move helpers.h to helper.h Lluís
2011-04-13 17:16 ` [Qemu-devel] [PATCH 1/4] [arm] trivial whitespace/indentation fixes Peter Maydell
2011-04-13 18:34 ` Aurelien Jarno [this message]
2011-04-13 20:06 ` Lluís
2011-04-13 20:09 ` Lluís
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110413183432.GA6142@volta.aurel32.net \
--to=aurelien@aurel32.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=xscript@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).