From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45229) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QA4ti-0002lk-Bp for qemu-devel@nongnu.org; Wed, 13 Apr 2011 14:34:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QA4th-00069q-1f for qemu-devel@nongnu.org; Wed, 13 Apr 2011 14:34:38 -0400 Received: from hall.aurel32.net ([88.191.126.93]:52339) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QA4tg-00069f-Rt for qemu-devel@nongnu.org; Wed, 13 Apr 2011 14:34:37 -0400 Date: Wed, 13 Apr 2011 20:34:32 +0200 From: Aurelien Jarno Message-ID: <20110413183432.GA6142@volta.aurel32.net> References: <20110413163816.20067.32914.stgit@ginnungagap.bsc.es> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 1/4] [arm] trivial whitespace/indentation fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: =?iso-8859-15?Q?Llu=EDs?= , qemu-devel@nongnu.org On Wed, Apr 13, 2011 at 06:16:55PM +0100, Peter Maydell wrote: > On 13 April 2011 17:38, Lluís wrote: > > Signed-off-by: Lluís Vilanova > > --- > >  target-arm/helper.c        |  246 ++++++++++++++++++++++---------------------- > >  target-arm/iwmmxt_helper.c |   28 +++-- > >  target-arm/translate.c     |   26 ++--- > >  3 files changed, 150 insertions(+), 150 deletions(-) > > My preference is not to do large-scale whitespace changes > unless the code's being touched in that area anyway, so > I'd prefer this not to be applied. > > (They make things painful for forks and branches, and > they make git blame less useful; disadvantages outweigh > the minor benefits of the cleanup IMHO.) > I agree that this patch should not be applied. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net