From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53118) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QAIZE-0008CD-1i for qemu-devel@nongnu.org; Thu, 14 Apr 2011 05:10:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QAIZC-0003A7-IH for qemu-devel@nongnu.org; Thu, 14 Apr 2011 05:10:24 -0400 Received: from mail.univention.de ([82.198.197.8]:2244) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QAIZC-00039l-8k for qemu-devel@nongnu.org; Thu, 14 Apr 2011 05:10:22 -0400 From: Philipp Hahn Date: Thu, 14 Apr 2011 11:10:08 +0200 References: <1280846670-27063-3-git-send-email-kwolf@redhat.com> In-Reply-To: <1280846670-27063-3-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1638476.9odG3Etyyj"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201104141110.13280.hahn@univention.de> Subject: [Qemu-devel] [BUG] Re: [2/6] loadvm: improve tests before bdrv_snapshot_goto() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: libvir-list@redhat.com, qemu-devel@nongnu.org --nextPart1638476.9odG3Etyyj Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Hello, Am Dienstag 03 August 2010 06:44:26 schrieb Kevin Wolf: > From: Miguel Di Ciurcio Filho > > This patch improves the resilience of the load_vmstate() function, doing > further and better ordered tests. This patch broke restoring not-running VMs using libvirt-0.8.7 with qemu-0.= 14:=20 When the domain is not running while taking a snpshot, the sn.vm_state_size= =20 =3D=3D 0: 2021 } else if (sn.vm_state_size =3D=3D 0) { (gdb) print sn $6 =3D {id_str =3D "1", '\0' , name =3D "pre-update-flas= h", '\0'=20 , vm_state_size =3D 0, date_sec =3D 1302698007, date_nse= c =3D=20 711909000,=20 vm_clock_nsec =3D 0} > The [old] process: =2E.. > - run bdrv_snapshot_goto() on devices > - if fails, give an warning and goes to the next (not good!) > - if fails on the VM state device, return zero (not good!) > - check if the requested snapshot exists on the device that saves the VM > state and the state is not zero > - if fails return -error Previously the qcow2 image was still reverted to the old state, so on the n= ext=20 start of the domain the qcow2 image would be in the state of the snapshot > New behavior: =2E.. > - check if the requested snapshot exists on the device that saves the VM > state and the state is not zero > - if fails return -error =2E.. > - run snapshot_goto() on devices Now the qcow2 image is not reverted and when the domain is started, it is N= OT=20 in the state of the snapshot. I can't decide if this regression is an Qemu bug or libvirt should be adapt= ed=20 to this new behavior. I found the Bug also reported with Ubuntu and created a Bug in our own Germ= an=20 bugtracker: Sincerely Philipp Hahn =2D-=20 Philipp Hahn Open Source Software Engineer hahn@univention.de Univention GmbH Linux for Your Business fon: +49 421 22 232- 0 Mary-Somerville-Str.1 D-28359 Bremen fax: +49 421 22 232-99 http://www.univention.de/ --nextPart1638476.9odG3Etyyj Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEABECAAYFAk2mufAACgkQYPlgoZpUDjl1JwCgghTZVDGAWZaVk9bwcma+cQKT Lb8Anjuq+j7ZoekMlXW7KvOFL3YpZgqQ =oQyW -----END PGP SIGNATURE----- --nextPart1638476.9odG3Etyyj--