From: Amit Shah <amit.shah@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 5/5] ide/atapi: Introduce NEED_DISK flag for commands
Date: Tue, 19 Apr 2011 18:48:54 +0530 [thread overview]
Message-ID: <20110419131854.GG16567@amit-x200.redhat.com> (raw)
In-Reply-To: <1303216603-11658-6-git-send-email-kwolf@redhat.com>
On (Tue) 19 Apr 2011 [14:36:43], Kevin Wolf wrote:
> diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c
> index 032d1b0..88e7791 100644
> --- a/hw/ide/atapi.c
> +++ b/hw/ide/atapi.c
> @@ -813,11 +813,7 @@ error_cmd:
>
> static void cmd_test_unit_ready(IDEState *s, uint8_t *buf)
> {
> - if (bdrv_is_inserted(s->bs)) {
> - ide_atapi_cmd_ok(s);
> - } else {
> - ide_atapi_cmd_error(s, SENSE_NOT_READY, ASC_MEDIUM_NOT_PRESENT);
> - }
> + ide_atapi_cmd_ok(s);
> }
It'll look really weird to have test_unit_ready() to always return
GOOD status (outside the context of this patch). A comment will help.
Amit
next prev parent reply other threads:[~2011-04-19 13:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-19 12:36 [Qemu-devel] [PATCH 0/5] atapi: Some code restructuring Kevin Wolf
2011-04-19 12:36 ` [Qemu-devel] [PATCH 1/5] ide: Split atapi.c out Kevin Wolf
2011-04-19 12:36 ` [Qemu-devel] [PATCH 2/5] ide/atapi: Factor some commands out Kevin Wolf
2011-04-19 12:36 ` [Qemu-devel] [PATCH 3/5] ide/atapi: Use table instead of switch for commands Kevin Wolf
2011-04-19 13:20 ` Amit Shah
2011-04-19 13:34 ` Kevin Wolf
2011-04-19 12:36 ` [Qemu-devel] [PATCH 4/5] ide/atapi: Replace bdrv_get_geometry calls by s->nb_sectors Kevin Wolf
2011-04-19 12:36 ` [Qemu-devel] [PATCH 5/5] ide/atapi: Introduce NEED_DISK flag for commands Kevin Wolf
2011-04-19 13:18 ` Amit Shah [this message]
2011-04-19 13:45 ` Kevin Wolf
2011-04-19 13:21 ` [Qemu-devel] [PATCH 0/5] atapi: Some code restructuring Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110419131854.GG16567@amit-x200.redhat.com \
--to=amit.shah@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).