From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:54108)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chrisw@redhat.com>) id 1QCJNR-000489-20
	for qemu-devel@nongnu.org; Tue, 19 Apr 2011 18:26:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <chrisw@redhat.com>) id 1QCJNQ-0003Bg-EU
	for qemu-devel@nongnu.org; Tue, 19 Apr 2011 18:26:33 -0400
Received: from mx1.redhat.com ([209.132.183.28]:5525)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chrisw@redhat.com>) id 1QCJNQ-0003Bb-45
	for qemu-devel@nongnu.org; Tue, 19 Apr 2011 18:26:32 -0400
Date: Tue, 19 Apr 2011 15:26:26 -0700
From: Chris Wright <chrisw@redhat.com>
Message-ID: <20110419222626.GP12133@x200.localdomain>
References: <20110419203234.4254.94914.stgit@s20.home>
	<20110419220743.GO12133@x200.localdomain>
	<1303251751.3110.129.camel@x201>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1303251751.3110.129.camel@x201>
Subject: Re: [Qemu-devel] [PATCH] vfio: Add an ioctl to reset the device
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <http://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: Chris Wright <chrisw@redhat.com>, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, qemu-devel@nongnu.org, aafabbri@cisco.com, dwang2@cisco.com, pugs@ieee.org, benve@cisco.com

* Alex Williamson (alex.williamson@redhat.com) wrote:
> On Tue, 2011-04-19 at 15:07 -0700, Chris Wright wrote:
> > * Alex Williamson (alex.williamson@redhat.com) wrote:
> > > When using VFIO to assign a device to a guest, we want to make sure
> > > the device is quiesced on VM reset to stop all DMA within the guest
> > > mapped memory.  Add an ioctl which just calls pci_reset_function()
> > > and returns whether it succeeds.
> > 
> > Shouldn't there be a reset when binding/unbinding vfio to/from a pci
> > device?
> 
> There's already one when the /dev/vfioX file is opened, we should add
> another on release, and probably add the same PCI save state store/load
> that I'm proposing for KVM across those.  Thanks,

Hmm, I looked and didn't see it, hence the question.