qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Aurelien Jarno <aurelien@aurel32.net>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] hw/arm_boot.c: move initrd load address up to accommodate large kernels
Date: Wed, 20 Apr 2011 13:02:29 +0200	[thread overview]
Message-ID: <20110420110229.GC24035@volta.aurel32.net> (raw)
In-Reply-To: <1303227154-31067-1-git-send-email-peter.maydell@linaro.org>

On Tue, Apr 19, 2011 at 04:32:34PM +0100, Peter Maydell wrote:
> Newer kernels are large enough that they can overlap the address
> where qemu places the initrd. Move the initrd up so that there is
> enough space for the kernel again.
> 
> Unfortunately it's not possible to automatically determine the
> size of the kernel if it is compressed, so this is the best we
> can do.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> I think a variant of this patch was posted some time last year but didn't
> attract any comment. Anyway, bumping up the arbitrary initrd load address
> is a bit ugly but does at least let large kernels boot, and corresponds
> to what you'd do on real hardware (ie change the load address in your
> u-boot script)...
> 
> If anybody has a better solution then I'm happy to implement it; otherwise
> I think this patch should be committed.
> 
>  hw/arm_boot.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Thanks, applied.

> diff --git a/hw/arm_boot.c b/hw/arm_boot.c
> index 41e99d1..bfac982 100644
> --- a/hw/arm_boot.c
> +++ b/hw/arm_boot.c
> @@ -15,7 +15,7 @@
>  
>  #define KERNEL_ARGS_ADDR 0x100
>  #define KERNEL_LOAD_ADDR 0x00010000
> -#define INITRD_LOAD_ADDR 0x00800000
> +#define INITRD_LOAD_ADDR 0x00d00000
>  
>  /* The worlds second smallest bootloader.  Set r0-r2, then jump to kernel.  */
>  static uint32_t bootloader[] = {
> -- 
> 1.7.1
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net

      reply	other threads:[~2011-04-20 11:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-19 15:32 [Qemu-devel] [PATCH] hw/arm_boot.c: move initrd load address up to accommodate large kernels Peter Maydell
2011-04-20 11:02 ` Aurelien Jarno [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110420110229.GC24035@volta.aurel32.net \
    --to=aurelien@aurel32.net \
    --cc=patches@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).