From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:46407)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgibson@ozlabs.org>) id 1QCYss-0002Q0-9E
	for qemu-devel@nongnu.org; Wed, 20 Apr 2011 11:00:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dgibson@ozlabs.org>) id 1QCYsq-0005Wa-KC
	for qemu-devel@nongnu.org; Wed, 20 Apr 2011 11:00:02 -0400
Received: from ozlabs.org ([203.10.76.45]:38627)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgibson@ozlabs.org>) id 1QCYsq-0005Vx-4e
	for qemu-devel@nongnu.org; Wed, 20 Apr 2011 11:00:00 -0400
Date: Thu, 21 Apr 2011 00:51:29 +1000
From: David Gibson <david@gibson.dropbear.id.au>
Message-ID: <20110420145129.GA11968@yookeroo>
References: <1303178626-30268-1-git-send-email-david@gibson.dropbear.id.au>
	<20110420123644.GC3519@amit-x200.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110420123644.GC3519@amit-x200.redhat.com>
Subject: Re: [Qemu-devel] [PATCH] virtio-serial: Fix endianness bug in the
	config space
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <http://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: Juan Quintela <quintela@redhat.com>, aik@ozlabs.ru, qemu-devel@nongnu.org, paulus@samba.org, anton@samba.org

On Wed, Apr 20, 2011 at 06:06:45PM +0530, Amit Shah wrote:
> On (Tue) 19 Apr 2011 [12:03:46], David Gibson wrote:
> > From: Alexey Kardashevskiy <aik@ozlabs.ru>
> > 
> > The virtio serial specification requres that the values in the config
> > space are encoded in native endian of the guest.
> > 
> > The qemu virtio-serial code did not do conversion to the guest endian
> > format what caused problems when host and guest use different format.
> > 
> > This patch corrects the qemu side, correctly doing host-native <->
> > guest-native conversions when accessing the config space. This won't
> > break any setups that aren't already broken, and fixes the case
> > of different host and guest endianness.
> > 
> > Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> 
> Thanks; please put your sign-off as well.

Oops.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson