qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: ronnie sahlberg <ronniesahlberg@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>,
	stefanha@linux.vnet.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] iSCSI support for QEMU
Date: Thu, 21 Apr 2011 11:09:35 +0200	[thread overview]
Message-ID: <20110421090935.GA5381@lst.de> (raw)
In-Reply-To: <BANLkTimC01Xx1uHzaCfp44msPPkThDvfEA@mail.gmail.com>

> In my patch, there are NO data integrity issues.
> Data is sent out on the wire immediately as the guest issues the write.
> Once the guest issues a flush call, the flush call will not terminate
> until the SYNCCACHE10 task has completed.

No guest will even issue a cache flush, as we claim to be WCE=0 by default.
Now if you target has WCE=1 it will cache data internally, and your
iscsi initiator will never flush it out to disk.

We only claim WCE=1 to the guest if cache=writeback or cache=none are
set.  So ignoring the issue of having a cache on the initiator side
you must implement stable writes for the default cache=writethrough
behaviour by either seeting the FUA bit on your writes, or doing
a cache flush after every write in case the target does not support FUA.

  reply	other threads:[~2011-04-21  9:09 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-21  8:43 [Qemu-devel] iSCSI support for QEMU Ronnie Sahlberg
2011-04-21  8:43 ` [Qemu-devel] [PATCH] iSCSI block driver support Ronnie Sahlberg
2011-04-21  8:50 ` [Qemu-devel] iSCSI support for QEMU Christoph Hellwig
2011-04-21  8:58   ` ronnie sahlberg
2011-04-21  9:09     ` Christoph Hellwig [this message]
2011-04-21  9:28       ` ronnie sahlberg
2011-04-21 10:58         ` Stefan Hajnoczi
2011-04-21 11:12           ` ronnie sahlberg
2011-04-21 11:21             ` Stefan Hajnoczi
2011-04-21 11:36               ` ronnie sahlberg
2011-04-21 11:44                 ` Kevin Wolf
2011-04-21 12:08                 ` Stefan Hajnoczi
2011-04-21 12:49                 ` Christoph Hellwig
2011-04-21 20:25                   ` ronnie sahlberg
2011-04-21  9:47       ` ronnie sahlberg
  -- strict thread matches above, loose matches on Subject: below --
2011-06-12  2:54 ronnie sahlberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110421090935.GA5381@lst.de \
    --to=hch@lst.de \
    --cc=qemu-devel@nongnu.org \
    --cc=ronniesahlberg@gmail.com \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).