From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:59809)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1QEIzQ-0004rn-4x
	for qemu-devel@nongnu.org; Mon, 25 Apr 2011 06:26:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1QEIzP-0007Eo-81
	for qemu-devel@nongnu.org; Mon, 25 Apr 2011 06:26:00 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58400)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1QEIzO-0007Ek-UW
	for qemu-devel@nongnu.org; Mon, 25 Apr 2011 06:25:59 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p3PAPv8a008601
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 25 Apr 2011 06:25:58 -0400
Date: Mon, 25 Apr 2011 15:55:52 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20110425102552.GE8308@amit-x200.redhat.com>
References: <1300961524-6205-1-git-send-email-hdegoede@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1300961524-6205-1-git-send-email-hdegoede@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/3] spicevmc -> chardev: restore guest
 open / close (v2)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hans de Goede <hdegoede@redhat.com>
Cc: qemu-devel@nongnu.org

On (Thu) 24 Mar 2011 [11:12:01], Hans de Goede wrote:
> Hi All,
> 
> When we moved from the spicevmc device (which directly implemented a virtio
> serial port) to doing spicevmc as a chardev backend we lost the notification
> of the guest opening / closing the port to spice server. This causes the
> server to not fall back to server mouse mode when the agent inside the
> guest stops / dies (for what ever reason). Which causes the mouse to
> stop working in this scenario. This patch set fixes this regression.
> 
> Changes since v1:
> -Replace "return qemu_chr_guest_open(vcon->chr);" with just
>  "qemu_chr_guest_open(vcon->chr);", since this is a void func. idem for close.

I've picked this up in the virtio-serial branch; will do a pull
request shortly.


		Amit