From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:53426)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bradh@frogmouth.net>) id 1QEAC3-0007ye-JZ
	for qemu-devel@nongnu.org; Sun, 24 Apr 2011 21:02:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bradh@frogmouth.net>) id 1QEAC2-00077s-QN
	for qemu-devel@nongnu.org; Sun, 24 Apr 2011 21:02:27 -0400
Received: from ipmail05.adl6.internode.on.net ([150.101.137.143]:34896)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bradh@frogmouth.net>) id 1QEAC2-00077X-ES
	for qemu-devel@nongnu.org; Sun, 24 Apr 2011 21:02:26 -0400
From: Brad Hards <bradh@frogmouth.net>
Date: Mon, 25 Apr 2011 11:02:17 +1000
References: <1302687934-1287-1-git-send-email-bradh@frogmouth.net>
	<4DA59C95.1020904@redhat.com>
	<201104140801.43238.bradh@frogmouth.net>
In-Reply-To: <201104140801.43238.bradh@frogmouth.net>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201104251102.17145.bradh@frogmouth.net>
Subject: Re: [Qemu-devel] [PATCH 4/4] usb: use DPRINTF instead of printf for
	some simple cases
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Hans de Goede <hdegoede@redhat.com>

On Thursday 14 April 2011 08:01:43 Brad Hards wrote:
> On Wed, 13 Apr 2011 10:52:37 pm Hans de Goede wrote:
> > > @@ -359,7 +359,7 @@ static int usb_host_claim_interfaces(USBHostDevice
> > > *dev, int configuration)
> > > 
> > >           ret = ioctl(dev->fd, USBDEVFS_CLAIMINTERFACE,&interface);
> > >           if (ret<  0) {
> > >           
> > >               if (errno == EBUSY) {
> > > 
> > > -                printf("husb: update iface. device already
> > > grabbed\n"); +                DPRINTF("husb: update iface. device
> > > already grabbed\n");
> > > 
> > >               } else {
> > >               
> > >                   perror("husb: failed to claim interface");
> > >               
> > >               }
> > 
> > Nack, this is an error condition, so it should not be a DPRINTF.
> 
> Then should it go to stderr instead of stdout?
> 
> (There are other places in this code where we use fprintf(stderr, ...) to
> indicate error conditions.)
ping?

Brad