From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:43997)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1QENHF-0004a1-Pz
	for qemu-devel@nongnu.org; Mon, 25 Apr 2011 11:00:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1QENHE-0002Yu-GA
	for qemu-devel@nongnu.org; Mon, 25 Apr 2011 11:00:41 -0400
Received: from mx1.redhat.com ([209.132.183.28]:54419)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1QENHE-0002Yl-4G
	for qemu-devel@nongnu.org; Mon, 25 Apr 2011 11:00:40 -0400
Date: Mon, 25 Apr 2011 12:00:30 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20110425120030.507b30a1@doriath>
In-Reply-To: <4DAE3CB4.6000302@cn.fujitsu.com>
References: <4D74A8C9.2020408@cn.fujitsu.com> <4D74A974.6090509@cn.fujitsu.com>
	<20110404105949.GA30324@redhat.com>
	<m3r59i439t.fsf@blackfin.pond.sub.org>
	<4D99C309.6060905@codemonkey.ws> <4DAE3CB4.6000302@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/2 V7] qemu,
 qmp: add inject-nmi qmp command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Lai Jiangshan <eag0628@gmail.com>, kvm@vger.kernel.org, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, Avi Kivity <avi@redhat.com>

On Wed, 20 Apr 2011 09:53:56 +0800
Lai Jiangshan <laijs@cn.fujitsu.com> wrote:

> On 04/04/2011 09:09 PM, Anthony Liguori wrote:
> > On 04/04/2011 07:19 AM, Markus Armbruster wrote:
> >> [Note cc: Anthony]
> >>
> >> "Daniel P. Berrange"<berrange@redhat.com>  writes:
> >>
> >>> On Mon, Mar 07, 2011 at 05:46:28PM +0800, Lai Jiangshan wrote:
> >>>> From: Lai Jiangshan<laijs@cn.fujitsu.com>
> >>>> Date: Mon, 7 Mar 2011 17:05:15 +0800
> >>>> Subject: [PATCH 2/2] qemu,qmp: add inject-nmi qmp command
> >>>>
> >>>> inject-nmi command injects an NMI on all CPUs of guest.
> >>>> It is only supported for x86 guest currently, it will
> >>>> returns "Unsupported" error for non-x86 guest.
> >>>>
> >>>> ---
> >>>>   hmp-commands.hx |    2 +-
> >>>>   monitor.c       |   18 +++++++++++++++++-
> >>>>   qmp-commands.hx |   29 +++++++++++++++++++++++++++++
> >>>>   3 files changed, 47 insertions(+), 2 deletions(-)
> >>> Does anyone have any feedback on this addition, or are all new
> >>> QMP patch proposals blocked pending Anthony's QAPI work ?
> >> That would be bad.  Anthony, what's holding this back?
> > 
> > It doesn't pass checkpath.pl.
> > 
> > But I'd also expect this to come through Luiz's QMP tree.
> > 
> > Regards,
> > 
> > Anthony Liguori
> > 
> 
> Hi, Anthony,
> 
> I cannot find checkpath.pl in the source tree.

It's ./scripts/checkpatch.pl

> And how/where to write errors descriptions? Is the following description
> suitable?
> 
> ##
> # @inject-nmi:
> #
> # Inject an NMI on the guest.
> #
> # Returns: Nothing on success.
> #          If the guest(non-x86) does not support NMI injection, Unsupported
> #
> # Since: 0.15.0
> ##
> { 'command': 'inject-nmi' }
> 
> 
> Thanks,
> Lai
>