From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59426) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QF5oY-0002KJ-GF for qemu-devel@nongnu.org; Wed, 27 Apr 2011 10:34:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QF5oU-0007YP-3r for qemu-devel@nongnu.org; Wed, 27 Apr 2011 10:34:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:23558) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QF5oT-0007Y3-Qm for qemu-devel@nongnu.org; Wed, 27 Apr 2011 10:33:58 -0400 Date: Wed, 27 Apr 2011 11:33:46 -0300 From: Luiz Capitulino Message-ID: <20110427113346.5bd7fcac@doriath> In-Reply-To: <4DB7775A.1010608@cn.fujitsu.com> References: <4D74A8C9.2020408@cn.fujitsu.com> <4D74A974.6090509@cn.fujitsu.com> <20110404105949.GA30324@redhat.com> <4D99BF99.1040305@redhat.com> <4D99C22C.4070401@codemonkey.ws> <20110406144723.45333682@doriath> <4D9CAAF9.7000509@codemonkey.ws> <20110406150818.56707b9b@doriath> <4DAE7AF4.3050508@cn.fujitsu.com> <4DAFA34A.3030701@cn.fujitsu.com> <20110426102641.71a60d81@doriath> <4DB6C8CB.7030706@codemonkey.ws> <4DB7775A.1010608@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 0/3 V8] QAPI: add inject-nmi qmp command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lai Jiangshan Cc: Lai Jiangshan , kvm@vger.kernel.org, Markus Armbruster , qemu-devel@nongnu.org, Avi Kivity On Wed, 27 Apr 2011 09:54:34 +0800 Lai Jiangshan wrote: > On 04/26/2011 09:29 PM, Anthony Liguori wrote: > > On 04/26/2011 08:26 AM, Luiz Capitulino wrote: > >> On Thu, 21 Apr 2011 11:23:54 +0800 > >> Lai Jiangshan wrote: > >> > >>> > >>> Hi, Anthony Liguori > >>> > >>> Any suggestion? > >>> > >>> Although all command line interfaces will be converted to to use QMP interfaces in 0.16, > >>> I hope inject-nmi come into QAPI earlier, 0.15. > >> > >> I don't know what Anthony thinks about adding new commands like this one that > >> early to the new QMP interface, but adding them to current QMP will certainly > >> cause less code churn on your side. That's what I'd recommend for now. > > > > Yeah, sorry, this whole series has been confused in the QAPI discussion. > > > > I did not intend for QAPI to be disruptive to current development. > > > > As far as I can tell, the last series that was posted (before the QAPI post) still had checkpatch.pl issues (scripts/checkpatch.pl btw) and we had agreed that once that was resolved, it would come in through Luiz's tree. > > > > Sorry, I didn't caught the meaning. > Fix checkpatch.pl issues of V7 Patch, and sent it again? Yes, my recommendation for your series is: 1. Address checkpatch.pl errors 2. Change the HMP to use your implementation, which send the NMI to all CPUs 3. Any other _code_ review comments I might be missing