From: Aurelien Jarno <aurelien@aurel32.net>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Benjamin Poirier <benjamin.poirier@gmail.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] rtl8139: Fix compilation for w32/w64
Date: Wed, 27 Apr 2011 16:23:03 +0200 [thread overview]
Message-ID: <20110427142303.GA31605@volta.aurel32.net> (raw)
In-Reply-To: <1303805868-9896-1-git-send-email-weil@mail.berlios.de>
On Tue, Apr 26, 2011 at 10:17:48AM +0200, Stefan Weil wrote:
> Compilation for Windows needs a different declaration for the
> printf format attribute, so use the macro which was defined for
> this purpose.
>
> Cc: Benjamin Poirier <benjamin.poirier@gmail.com>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
> hw/rtl8139.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
Thanks, applied.
> diff --git a/hw/rtl8139.c b/hw/rtl8139.c
> index 623fb0c..b997fe7 100644
> --- a/hw/rtl8139.c
> +++ b/hw/rtl8139.c
> @@ -88,8 +88,7 @@
> # define DPRINTF(fmt, ...) \
> do { fprintf(stderr, "RTL8139: " fmt, ## __VA_ARGS__); } while (0)
> #else
> -static inline __attribute__ ((format (printf, 1, 2)))
> - int DPRINTF(const char *fmt, ...)
> +static inline GCC_FMT_ATTR(1, 2) int DPRINTF(const char *fmt, ...)
> {
> return 0;
> }
> --
> 1.7.2.5
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
prev parent reply other threads:[~2011-04-27 14:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-26 8:17 [Qemu-devel] [PATCH] rtl8139: Fix compilation for w32/w64 Stefan Weil
2011-04-27 14:23 ` Aurelien Jarno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110427142303.GA31605@volta.aurel32.net \
--to=aurelien@aurel32.net \
--cc=benjamin.poirier@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=weil@mail.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).