From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:52366)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1QF5e2-0003cR-W2
	for qemu-devel@nongnu.org; Wed, 27 Apr 2011 10:23:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1QF5dy-0005xX-J7
	for qemu-devel@nongnu.org; Wed, 27 Apr 2011 10:23:10 -0400
Received: from hall.aurel32.net ([88.191.126.93]:55907)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1QF5dy-0005xS-8D
	for qemu-devel@nongnu.org; Wed, 27 Apr 2011 10:23:06 -0400
Date: Wed, 27 Apr 2011 16:23:03 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20110427142303.GA31605@volta.aurel32.net>
References: <1303805868-9896-1-git-send-email-weil@mail.berlios.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <1303805868-9896-1-git-send-email-weil@mail.berlios.de>
Subject: Re: [Qemu-devel] [PATCH] rtl8139: Fix compilation for w32/w64
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Benjamin Poirier <benjamin.poirier@gmail.com>, QEMU Developers <qemu-devel@nongnu.org>

On Tue, Apr 26, 2011 at 10:17:48AM +0200, Stefan Weil wrote:
> Compilation for Windows needs a different declaration for the
> printf format attribute, so use the macro which was defined for
> this purpose.
> 
> Cc: Benjamin Poirier <benjamin.poirier@gmail.com>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
>  hw/rtl8139.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)

Thanks, applied.

> diff --git a/hw/rtl8139.c b/hw/rtl8139.c
> index 623fb0c..b997fe7 100644
> --- a/hw/rtl8139.c
> +++ b/hw/rtl8139.c
> @@ -88,8 +88,7 @@
>  #  define DPRINTF(fmt, ...) \
>      do { fprintf(stderr, "RTL8139: " fmt, ## __VA_ARGS__); } while (0)
>  #else
> -static inline __attribute__ ((format (printf, 1, 2)))
> -    int DPRINTF(const char *fmt, ...)
> +static inline GCC_FMT_ATTR(1, 2) int DPRINTF(const char *fmt, ...)
>  {
>      return 0;
>  }
> -- 
> 1.7.2.5
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net