qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] Fix typo in phys memory client registration path
@ 2011-04-28 19:43 Alex Williamson
  0 siblings, 0 replies; only message in thread
From: Alex Williamson @ 2011-04-28 19:43 UTC (permalink / raw)
  To: qemu-devel, mst; +Cc: alex.williamson

When we register a physical memory client, we try to walk the page
tables, calling the set_memory hook for every entry.  Effectively
playing catchup for the client for everything already registered.
This typo prevents us from walking most of the page tables.

Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---

This seems right, but I'm not sure what kind of fallout we're
going to get in vhost.  kvm is the only other user of the phys
memory client interface, but it registers very early, so I don't
expect it to see much change.

 exec.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/exec.c b/exec.c
index c037389..4752af1 100644
--- a/exec.c
+++ b/exec.c
@@ -1770,7 +1770,7 @@ static void phys_page_for_each(CPUPhysMemoryClient *client)
     int i;
     for (i = 0; i < P_L1_SIZE; ++i) {
         phys_page_for_each_1(client, P_L1_SHIFT / L2_BITS - 1,
-                             l1_phys_map + 1);
+                             l1_phys_map + i);
     }
 }
 

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2011-04-28 19:43 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-28 19:43 [Qemu-devel] [PATCH] Fix typo in phys memory client registration path Alex Williamson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).