From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39673) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QFX7e-0000dW-5D for qemu-devel@nongnu.org; Thu, 28 Apr 2011 15:43:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QFX7d-0004sQ-8t for qemu-devel@nongnu.org; Thu, 28 Apr 2011 15:43:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54757) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QFX7d-0004ro-0Q for qemu-devel@nongnu.org; Thu, 28 Apr 2011 15:43:33 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p3SJhUoF029005 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 28 Apr 2011 15:43:30 -0400 From: Alex Williamson Date: Thu, 28 Apr 2011 13:43:29 -0600 Message-ID: <20110428194025.32536.62624.stgit@s20.home> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH] Fix typo in phys memory client registration path List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, mst@redhat.com Cc: alex.williamson@redhat.com When we register a physical memory client, we try to walk the page tables, calling the set_memory hook for every entry. Effectively playing catchup for the client for everything already registered. This typo prevents us from walking most of the page tables. Signed-off-by: Alex Williamson --- This seems right, but I'm not sure what kind of fallout we're going to get in vhost. kvm is the only other user of the phys memory client interface, but it registers very early, so I don't expect it to see much change. exec.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/exec.c b/exec.c index c037389..4752af1 100644 --- a/exec.c +++ b/exec.c @@ -1770,7 +1770,7 @@ static void phys_page_for_each(CPUPhysMemoryClient *client) int i; for (i = 0; i < P_L1_SIZE; ++i) { phys_page_for_each_1(client, P_L1_SHIFT / L2_BITS - 1, - l1_phys_map + 1); + l1_phys_map + i); } }