From: Scott Wood <scottwood@freescale.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: agraf@suse.de, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] monitor: add PPC BookE SPRs
Date: Fri, 29 Apr 2011 10:49:18 -0500 [thread overview]
Message-ID: <20110429104918.41a84d6d@schlenkerla.am.freescale.net> (raw)
In-Reply-To: <4DBAA983.8050006@siemens.com>
On Fri, 29 Apr 2011 14:05:23 +0200
Jan Kiszka <jan.kiszka@siemens.com> wrote:
> On 2011-04-28 23:01, Scott Wood wrote:
> > +#ifdef KVM_CAP_PPC_BOOKE_SREGS
> > + if (kvm_check_extension(env->kvm_state, KVM_CAP_PPC_BOOKE_SREGS)) {
>
> You probably want to cache the result of this syscall during init and
> check that here. There are plenty examples for this pattern around.
OK.
> > + ret = kvm_vcpu_ioctl(env, KVM_GET_SREGS, &sregs);
> > + if (ret < 0)
> > + return ret;
>
> Please use chechpatch.pl before submitting.
Doh, will fix.
-Scott
prev parent reply other threads:[~2011-04-29 15:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 21:01 [Qemu-devel] [PATCH] monitor: add PPC BookE SPRs Scott Wood
2011-04-29 12:05 ` Jan Kiszka
2011-04-29 15:49 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110429104918.41a84d6d@schlenkerla.am.freescale.net \
--to=scottwood@freescale.com \
--cc=agraf@suse.de \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).