From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:33542)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <B07421@freescale.com>) id 1QFpwc-0005xn-Ab
	for qemu-devel@nongnu.org; Fri, 29 Apr 2011 11:49:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <B07421@freescale.com>) id 1QFpwb-0002Yw-A1
	for qemu-devel@nongnu.org; Fri, 29 Apr 2011 11:49:26 -0400
Received: from ch1ehsobe006.messaging.microsoft.com ([216.32.181.186]:48977
	helo=ch1outboundpool.messaging.microsoft.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <B07421@freescale.com>) id 1QFpwb-0002Ys-4A
	for qemu-devel@nongnu.org; Fri, 29 Apr 2011 11:49:25 -0400
Date: Fri, 29 Apr 2011 10:49:18 -0500
From: Scott Wood <scottwood@freescale.com>
Message-ID: <20110429104918.41a84d6d@schlenkerla.am.freescale.net>
In-Reply-To: <4DBAA983.8050006@siemens.com>
References: <20110428210130.GA15821@schlenkerla.am.freescale.net>
	<4DBAA983.8050006@siemens.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] monitor: add PPC BookE SPRs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: agraf@suse.de, qemu-devel@nongnu.org

On Fri, 29 Apr 2011 14:05:23 +0200
Jan Kiszka <jan.kiszka@siemens.com> wrote:

> On 2011-04-28 23:01, Scott Wood wrote:
> > +#ifdef KVM_CAP_PPC_BOOKE_SREGS
> > +    if (kvm_check_extension(env->kvm_state, KVM_CAP_PPC_BOOKE_SREGS)) {
> 
> You probably want to cache the result of this syscall during init and
> check that here. There are plenty examples for this pattern around.

OK.

> > +        ret = kvm_vcpu_ioctl(env, KVM_GET_SREGS, &sregs);
> > +        if (ret < 0)
> > +            return ret;
> 
> Please use chechpatch.pl before submitting.

Doh, will fix.

-Scott