* [Qemu-devel] [PATCH] vfio: Fix free in dma mapping error path
@ 2011-04-29 22:05 Alex Williamson
2011-05-04 19:19 ` Tom Lyon
0 siblings, 1 reply; 2+ messages in thread
From: Alex Williamson @ 2011-04-29 22:05 UTC (permalink / raw)
To: pugs; +Cc: chrisw, linux-pci, alex.williamson, linux-kernel, qemu-devel
This is allocated via vmalloc, so needs vfree, not kfree.
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
drivers/vfio/vfio_dma.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/vfio/vfio_dma.c b/drivers/vfio/vfio_dma.c
index cee1a25..4a488b6 100644
--- a/drivers/vfio/vfio_dma.c
+++ b/drivers/vfio/vfio_dma.c
@@ -322,7 +322,7 @@ int vfio_dma_map_common(struct vfio_listener *listener,
if (ret != npage) {
printk(KERN_ERR "%s: get_user_pages_fast returns %d, not %d\n",
__func__, ret, npage);
- kfree(pages);
+ vfree(pages);
ret = -EFAULT;
goto out_lock;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] vfio: Fix free in dma mapping error path
2011-04-29 22:05 [Qemu-devel] [PATCH] vfio: Fix free in dma mapping error path Alex Williamson
@ 2011-05-04 19:19 ` Tom Lyon
0 siblings, 0 replies; 2+ messages in thread
From: Tom Lyon @ 2011-05-04 19:19 UTC (permalink / raw)
To: Alex Williamson; +Cc: chrisw, linux-pci, pugs, linux-kernel, qemu-devel
On Friday, April 29, 2011 03:05:54 pm Alex Williamson wrote:
> This is allocated via vmalloc, so needs vfree, not kfree.
>
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> ---
>
> drivers/vfio/vfio_dma.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/vfio/vfio_dma.c b/drivers/vfio/vfio_dma.c
> index cee1a25..4a488b6 100644
> --- a/drivers/vfio/vfio_dma.c
> +++ b/drivers/vfio/vfio_dma.c
> @@ -322,7 +322,7 @@ int vfio_dma_map_common(struct vfio_listener *listener,
> if (ret != npage) {
> printk(KERN_ERR "%s: get_user_pages_fast returns %d, not %d\n",
> __func__, ret, npage);
> - kfree(pages);
> + vfree(pages);
> ret = -EFAULT;
> goto out_lock;
> }
Applied. Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-05-04 19:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-29 22:05 [Qemu-devel] [PATCH] vfio: Fix free in dma mapping error path Alex Williamson
2011-05-04 19:19 ` Tom Lyon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).