From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:46837)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1QGnRc-0007wJ-3Y
	for qemu-devel@nongnu.org; Mon, 02 May 2011 03:21:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1QGnRW-0000Eu-KQ
	for qemu-devel@nongnu.org; Mon, 02 May 2011 03:21:24 -0400
Received: from mx1.redhat.com ([209.132.183.28]:13628)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1QGnRW-0000Ea-8o
	for qemu-devel@nongnu.org; Mon, 02 May 2011 03:21:18 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p427LGpa007068
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 2 May 2011 03:21:16 -0400
Received: from localhost (ovpn-113-42.phx2.redhat.com [10.3.113.42])
	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP
	id p427LDsT025583
	for <qemu-devel@nongnu.org>; Mon, 2 May 2011 03:21:15 -0400
Date: Mon, 2 May 2011 12:51:12 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20110502072112.GF8308@amit-x200.redhat.com>
References: <1304076306-15867-1-git-send-email-alevy@redhat.com>
	<20110429125649.GA19028@amit-x200.redhat.com>
	<20110430082342.GB16190@amber.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110430082342.GB16190@amber.local>
Subject: Re: [Qemu-devel] [PATCHv3] virtio-serial-bus: use bh for
	unthrottling
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On (Sat) 30 Apr 2011 [11:23:42], Alon Levy wrote:
> On Fri, Apr 29, 2011 at 06:26:49PM +0530, Amit Shah wrote:
> > On (Fri) 29 Apr 2011 [14:25:06], Alon Levy wrote:
> > > Instead of calling flush_queued_data when unthrottling, schedule
> > > a bh. That way we can return immediately to the caller, and the
> > > flush uses the same call path as a have_data for callbackee.
> > > 
> > > No migration change is required because bh are called from vm_stop.
> > 
> > No sign-off?
> > 
> > The initial tests look good, no fireworks yet.
> > 
> > 		Amit
> 
> Can I reply with a sign off?
> 
> Signed-off-by: Alon Levy <alevy@redhat.com>

Yes, this is fine.

		Amit