From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:33533)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1QGoju-0002e7-2I
	for qemu-devel@nongnu.org; Mon, 02 May 2011 04:44:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1QGojp-0001k9-7y
	for qemu-devel@nongnu.org; Mon, 02 May 2011 04:44:22 -0400
Date: Mon, 2 May 2011 11:44:09 +0300
From: Alon Levy <alevy@redhat.com>
Message-ID: <20110502084409.GE17629@playa.redhat.com>
References: <1304322846-24376-1-git-send-email-pbonzini@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1304322846-24376-1-git-send-email-pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/4] libcacard: add correct subdirectory
 dependencies
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org

On Mon, May 02, 2011 at 09:54:03AM +0200, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Cc: qemu-trivial@nongnu.org
> ---
>  Makefile           |    2 ++
>  Makefile.objs      |    7 +++----
>  libcacard/Makefile |    9 +--------
>  3 files changed, 6 insertions(+), 12 deletions(-)
> 

Reviewed-by: Alon Levy <alevy@redhat.com>

> diff --git a/Makefile b/Makefile
> index 67c0268..2b0438c 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -88,6 +88,8 @@ include $(SRC_PATH)/Makefile.objs
>  endif
>  
>  $(common-obj-y): $(GENERATED_HEADERS)
> +subdir-libcacard: $(oslib-obj-y) $(trace-obj-y) qemu-malloc.o qemu-timer-common.o
> +
>  $(filter %-softmmu,$(SUBDIR_RULES)): $(trace-obj-y) $(common-obj-y) subdir-libdis
>  
>  $(filter %-user,$(SUBDIR_RULES)): $(GENERATED_HEADERS) $(trace-obj-y) subdir-libdis-user subdir-libuser
> diff --git a/Makefile.objs b/Makefile.objs
> index 44ce368..0ba989f 100644
> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@ -7,8 +7,8 @@ qobject-obj-y += qerror.o
>  #######################################################################
>  # oslib-obj-y is code depending on the OS (win32 vs posix)
>  oslib-obj-y = osdep.o
> -oslib-obj-$(CONFIG_WIN32) += oslib-win32.o
> -oslib-obj-$(CONFIG_POSIX) += oslib-posix.o
> +oslib-obj-$(CONFIG_WIN32) += oslib-win32.o qemu-thread-win32.o
> +oslib-obj-$(CONFIG_POSIX) += oslib-posix.o qemu-thread-posix.o
>  
>  #######################################################################
>  # block-obj-y is code used by both qemu system emulation and qemu-img
> @@ -143,8 +143,7 @@ common-obj-y += $(addprefix ui/, $(ui-obj-y))
>  common-obj-$(CONFIG_VNC) += $(addprefix ui/, $(vnc-obj-y))
>  
>  common-obj-y += iov.o acl.o
> -common-obj-$(CONFIG_POSIX) += qemu-thread-posix.o compatfd.o
> -common-obj-$(CONFIG_WIN32) += qemu-thread-win32.o
> +common-obj-$(CONFIG_POSIX) += compatfd.o
>  common-obj-y += notify.o event_notifier.o
>  common-obj-y += qemu-timer.o qemu-timer-common.o
>  
> diff --git a/libcacard/Makefile b/libcacard/Makefile
> index 4010029..1d34df0 100644
> --- a/libcacard/Makefile
> +++ b/libcacard/Makefile
> @@ -4,14 +4,7 @@
>  
>  $(call set-vpath, $(SRC_PATH):$(SRC_PATH)/libcacard)
>  
> -ifeq ($(CONFIG_WIN32),y)
> -QEMU_THREAD=qemu-thread-win32.o
> -else
> -QEMU_THREAD=qemu-thread-posix.o
> -endif
> -
> -
> -QEMU_OBJS=$(addprefix ../, $(QEMU_THREAD) $(oslib-obj-y) $(trace-obj-y) qemu-malloc.o qemu-timer-common.o)
> +QEMU_OBJS=$(addprefix ../, $(oslib-obj-y) $(trace-obj-y) qemu-malloc.o qemu-timer-common.o)
>  
>  QEMU_CFLAGS+=-I../
>  
> -- 
> 1.7.4.4
> 
> 
>