From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:39699)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1QGvVV-0007Lv-45
	for qemu-devel@nongnu.org; Mon, 02 May 2011 11:57:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1QGvVU-0008Vs-28
	for qemu-devel@nongnu.org; Mon, 02 May 2011 11:57:57 -0400
Received: from mx1.redhat.com ([209.132.183.28]:6971)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1QGvVT-0008Vk-Pk
	for qemu-devel@nongnu.org; Mon, 02 May 2011 11:57:56 -0400
Date: Mon, 2 May 2011 12:57:46 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20110502125746.5ef8bc78@doriath>
In-Reply-To: <BANLkTi=3K2t1H-nuq4fp_eRTLKiTKjaTXg@mail.gmail.com>
References: <1304116821-18201-1-git-send-email-lcapitulino@redhat.com>
	<BANLkTi=3K2t1H-nuq4fp_eRTLKiTKjaTXg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/3]: QMP: Introduce inject-nmi command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: laijs@cn.fujitsu.com, qemu-devel@nongnu.org, armbru@redhat.com

On Sat, 30 Apr 2011 09:33:15 +0300
Blue Swirl <blauwirbel@gmail.com> wrote:

> On Sat, Apr 30, 2011 at 1:40 AM, Luiz Capitulino <lcapitulino@redhat.com> wrote:
> > This series introduces the inject-nmi command for QMP, which sends an
> > NMI to _all_ guest's CPUs.
> >
> > Also note that this series changes the human monitor nmi command to use
> > the QMP implementation, which means that it now has a DIFFERENT behavior.
> > Please, check patch 3/3 for details.
> 
> As discussed earlier, please change the QMP version for future
> expandability so that instead of single command 'inject-nmi', 'inject'
> takes parameter 'nmi'. HMP command 'nmi' can remain for now, but
> 'inject' should be added.

I'm not sure I agree with this, because we risky overloading 'inject' the
same way we did with the 'change' command.

What's 'inject' supposed to do in the future?