From: Alex Williamson <alex.williamson@redhat.com>
To: qemu-devel@nongnu.org, anthony@codemonkey.ws
Cc: jan.kiszka@siemens.com, alex.williamson@redhat.com,
armbru@redhat.com, mst@redhat.com
Subject: [Qemu-devel] [PATCH v2 1/3] CPUPhysMemoryClient: Fix typo in phys memory client registration
Date: Tue, 03 May 2011 12:36:32 -0600 [thread overview]
Message-ID: <20110503183625.28430.83717.stgit@s20.home> (raw)
In-Reply-To: <20110503182039.28430.26530.stgit@s20.home>
When we register a physical memory client, we try to walk the page
tables, calling the set_memory hook for every entry. Effectively
playing catchup for the client for everything already registered.
With this type, we only walk the 2nd entry of the l1 table,
typically missing all of the registered memory.
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
exec.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/exec.c b/exec.c
index c3dc68a..8790ad8 100644
--- a/exec.c
+++ b/exec.c
@@ -1770,7 +1770,7 @@ static void phys_page_for_each(CPUPhysMemoryClient *client)
int i;
for (i = 0; i < P_L1_SIZE; ++i) {
phys_page_for_each_1(client, P_L1_SHIFT / L2_BITS - 1,
- l1_phys_map + 1);
+ l1_phys_map + i);
}
}
next prev parent reply other threads:[~2011-05-03 18:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-03 18:36 [Qemu-devel] [PATCH v2 0/3] CPUPhysMemoryClient: Fixes and batching Alex Williamson
2011-05-03 18:36 ` Alex Williamson [this message]
2011-05-03 18:36 ` [Qemu-devel] [PATCH v2 2/3] CPUPhysMemoryClient: Pass guest physical address not region offset Alex Williamson
2011-05-03 18:36 ` [Qemu-devel] [PATCH v2 3/3] CPUPhysMemoryClient: Batch contiguous addresses when playing catchup Alex Williamson
2011-05-05 13:21 ` Michael S. Tsirkin
2011-05-05 14:21 ` Alex Williamson
2011-05-05 14:30 ` Jes Sorensen
2011-05-05 15:18 ` Michael S. Tsirkin
2011-05-05 15:36 ` Jes Sorensen
2011-05-05 15:38 ` Michael S. Tsirkin
2011-05-05 15:40 ` Jes Sorensen
2011-05-05 15:41 ` Michael S. Tsirkin
2011-05-05 15:21 ` Michael S. Tsirkin
2011-05-25 3:47 ` Alex Williamson
2011-05-25 6:08 ` Michael S. Tsirkin
2011-05-05 13:21 ` [Qemu-devel] [PATCH v2 0/3] CPUPhysMemoryClient: Fixes and batching Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110503183625.28430.83717.stgit@s20.home \
--to=alex.williamson@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=armbru@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).