From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40690) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QHKSa-0004xF-Kt for qemu-devel@nongnu.org; Tue, 03 May 2011 14:36:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QHKSZ-0001g0-Qa for qemu-devel@nongnu.org; Tue, 03 May 2011 14:36:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54554) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QHKSZ-0001ft-Fh for qemu-devel@nongnu.org; Tue, 03 May 2011 14:36:35 -0400 From: Alex Williamson Date: Tue, 03 May 2011 12:36:32 -0600 Message-ID: <20110503183625.28430.83717.stgit@s20.home> In-Reply-To: <20110503182039.28430.26530.stgit@s20.home> References: <20110503182039.28430.26530.stgit@s20.home> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH v2 1/3] CPUPhysMemoryClient: Fix typo in phys memory client registration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, anthony@codemonkey.ws Cc: jan.kiszka@siemens.com, alex.williamson@redhat.com, armbru@redhat.com, mst@redhat.com When we register a physical memory client, we try to walk the page tables, calling the set_memory hook for every entry. Effectively playing catchup for the client for everything already registered. With this type, we only walk the 2nd entry of the l1 table, typically missing all of the registered memory. Signed-off-by: Alex Williamson --- exec.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/exec.c b/exec.c index c3dc68a..8790ad8 100644 --- a/exec.c +++ b/exec.c @@ -1770,7 +1770,7 @@ static void phys_page_for_each(CPUPhysMemoryClient *client) int i; for (i = 0; i < P_L1_SIZE; ++i) { phys_page_for_each_1(client, P_L1_SHIFT / L2_BITS - 1, - l1_phys_map + 1); + l1_phys_map + i); } }