From: Lluís <xscript@gmx.net>
To: qemu-devel@nongnu.org
Cc: stefanha@gmail.com, chouteau@adacore.com
Subject: [Qemu-devel] [RFC][PATCH v4 00/10] trace-state: make the behaviour of "disable" consistent across all backends
Date: Tue, 03 May 2011 22:40:42 +0200 [thread overview]
Message-ID: <20110503204042.438.2257.stgit@ginnungagap.bsc.es> (raw)
This patch defines the "disable" trace event state to always use the "nop"
backend.
As a side-effect, all events are now enabled (without "disable") by default, as
all backends (except "stderr") have programmatic support for dynamically
(de)activating each trace event.
In order to make this true, the "simple" backend now has a "-trace
events=<file>" argument to let the user select which events must be enabled from
the very beginning.
NOTES:
* Parsing of -trace arguments is not done in the OS-specific frontends.
Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
---
Changes in v4:
* Fix a couple of minor errors.
Changes in v3:
* Rebase on qemu.git/master (642cfd4d31241c0fc65c520cb1e703659af66236).
* Remove already-merged patches.
* Remove code styling patches.
* Generalize programmatic interface for trace event state control.
Changes in v2:
* Documentation fixes.
* Seggregate whitespace/indentation changes.
* Minor code beautifications.
* Make all -trace suboptions explicit.
* Fix minor comments from Stefan.
* Minor trace-events format fixes.
* Integrate changes from Fabien.
* Rebase on qemu.git/master (c8f930c0eeb696d638f4d4bf654e955fa44ff40f).
Lluís Vilanova (10):
trace: move backend-specific code into the trace/ directory
trace: avoid conditional code compilation during option parsing
trace: generalize the "property" concept in the trace-events file
trace-state: separate trace event control and query routines from the simple backend
trace-state: always compile support for controlling and querying trace event states
trace-state: add "-trace events" argument to control initial state
trace-state: always use the "nop" backend on events with the "disable" keyword
trace-state: [simple] disable all trace points by default
trace-state: [stderr] add support for dynamically enabling/disabling events
trace: enable all events
.gitignore | 2
Makefile | 1
Makefile.objs | 5 -
configure | 7 +
docs/tracing.txt | 64 ++++---
hmp-commands.hx | 9 +
monitor.c | 19 +-
qemu-config.c | 7 -
qemu-options.hx | 26 ++-
scripts/tracetool | 116 ++++++------
simpletrace.c | 355 --------------------------------------
simpletrace.h | 48 -----
trace-events | 495 ++++++++++++++++++++++++++---------------------------
trace/control.c | 66 +++++++
trace/control.h | 16 ++
trace/simple.c | 332 ++++++++++++++++++++++++++++++++++++
trace/simple.h | 46 +++++
trace/stderr.h | 11 +
vl.c | 21 ++
19 files changed, 877 insertions(+), 769 deletions(-)
delete mode 100644 simpletrace.c
delete mode 100644 simpletrace.h
create mode 100644 trace/control.c
create mode 100644 trace/control.h
create mode 100644 trace/simple.c
create mode 100644 trace/simple.h
create mode 100644 trace/stderr.h
next reply other threads:[~2011-05-03 20:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-03 20:40 Lluís [this message]
2011-05-03 20:40 ` [Qemu-devel] [PATCH v4 01/10] trace: move backend-specific code into the trace/ directory Lluís
2011-05-03 20:40 ` [Qemu-devel] [PATCH v4 02/10] trace: avoid conditional code compilation during option parsing Lluís
2011-05-03 20:41 ` [Qemu-devel] [PATCH v4 03/10] trace: generalize the "property" concept in the trace-events file Lluís
2011-05-03 20:41 ` [Qemu-devel] [PATCH v4 04/10] trace-state: separate trace event control and query routines from the simple backend Lluís
2011-05-03 20:41 ` [Qemu-devel] [PATCH v4 05/10] trace-state: always compile support for controlling and querying trace event states Lluís
2011-05-03 20:41 ` [Qemu-devel] [PATCH v4 06/10] trace-state: add "-trace events" argument to control initial state Lluís
2011-05-03 20:41 ` [Qemu-devel] [PATCH v4 07/10] trace-state: always use the "nop" backend on events with the "disable" keyword Lluís
2011-05-03 20:41 ` [Qemu-devel] [PATCH v4 08/10] trace-state: [simple] disable all trace points by default Lluís
2011-05-03 20:41 ` [Qemu-devel] [PATCH v4 09/10] trace-state: [stderr] add support for dynamically enabling/disabling events Lluís
2011-05-04 14:17 ` Lluís
2011-05-03 20:41 ` [Qemu-devel] [PATCH v4 10/10] trace: enable all events Lluís
2011-05-19 14:10 ` [Qemu-devel] [RFC][PATCH v4 00/10] trace-state: make the behaviour of "disable" consistent across all backends Lluís
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110503204042.438.2257.stgit@ginnungagap.bsc.es \
--to=xscript@gmx.net \
--cc=chouteau@adacore.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).