From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34161) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QHcgn-0005eD-Ex for qemu-devel@nongnu.org; Wed, 04 May 2011 10:04:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QHcgj-0004g2-JU for qemu-devel@nongnu.org; Wed, 04 May 2011 10:04:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13375) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QHcgj-0004fo-82 for qemu-devel@nongnu.org; Wed, 04 May 2011 10:04:25 -0400 Date: Wed, 4 May 2011 16:04:19 +0200 From: Andrea Arcangeli Message-ID: <20110504140419.GI7838@random.random> References: <20110503200339.GA7838@random.random> <4DC1096C.6040806@redhat.com> <20110504134119.GG7838@random.random> <4DC15B48.4010101@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4DC15B48.4010101@redhat.com> Subject: Re: [Qemu-devel] [PATCH] ide: cleanup warnings List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, Christoph Hellwig On Wed, May 04, 2011 at 03:57:28PM +0200, Kevin Wolf wrote: > I can't see how you could leave ide_dma_cb without either scheduling > another AIO request or setting aiocb = NULL in ide_set_inactive. I guess > I need to reproduce this and do some debugging... That would be nice to be sure. This has been triggering on a older codebase, it's uncertain if this would happen with current code too. The \n so far was the only obvious improvement I could make to the upstream code, until we understand better what's going on... The good thing is it doesn't seem to cause problems, other than the printf. The leftover in the dma->aiocb likely gets overwritten when guest retries without failure.