From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48800) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QHxsk-00030q-Q9 for qemu-devel@nongnu.org; Thu, 05 May 2011 08:42:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QHxsi-0005jW-FI for qemu-devel@nongnu.org; Thu, 05 May 2011 08:42:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2339) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QHxsi-0005j9-4H for qemu-devel@nongnu.org; Thu, 05 May 2011 08:42:12 -0400 Date: Thu, 5 May 2011 15:41:57 +0300 From: "Michael S. Tsirkin" Message-ID: <20110505124157.GA30119@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 0/7] pci: initialize ids in pci common code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Isaku Yamahata Cc: qemu-devel@nongnu.org On Fri, Apr 08, 2011 at 09:52:59PM +0900, Isaku Yamahata wrote: > vender id/device id... in configuration space are read-only registers > which are commonly defined for all pci devices. > So initialize them in common code and it simplifies the initialization a bit. > I converted some of them. > > If this is the right direction, I'll convert the remaining devices. So I agree about device vendor id and revision but not header type: devices ideally should supply device type (bridge or not) and we will fill it in correctly. > Isaku Yamahata (7): > pci: move ids of config space into PCIDeviceInfo > usb-uhci: convert to PCIDEviceInfo to initialize ids > eepro100: convert to PCIDeviceInfo to initialize ids > dec_pci: convert to PCIDeviceInfo to initialize ids > apb_pci: convert to PCIDeviceInfo to initialize ids > ide/piix: convert to PCIDeviceInfo to initialize ids > vmware_vga.c: convert to PCIDeviceInfo to initialize ids > > hw/apb_pci.c | 13 +++++------ > hw/dec_pci.c | 27 +++++++----------------- > hw/eepro100.c | 60 ++++++++++++++++++++++++------------------------------ > hw/ide/piix.c | 29 +++++++------------------- > hw/pci.c | 46 +++++++++++++++++++++++++++++------------ > hw/pci.h | 9 ++++++++ > hw/usb-uhci.c | 38 ++++++++++------------------------ > hw/vmware_vga.c | 13 +++++------ > 8 files changed, 107 insertions(+), 128 deletions(-)