From: "Michael S. Tsirkin" <mst@redhat.com>
To: Stefan Weil <weil@mail.berlios.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL v2] eepro100: Update of patch series (fixes and enhancements)
Date: Thu, 5 May 2011 16:01:12 +0300 [thread overview]
Message-ID: <20110505130112.GD30119@redhat.com> (raw)
In-Reply-To: <1304196013-14432-1-git-send-email-weil@mail.berlios.de>
On Sat, Apr 30, 2011 at 10:40:03PM +0200, Stefan Weil wrote:
> Hi,
>
> this is the second version of a series of patches for eepro100 which mainly
> fix endianness issues and enhance register access. There was a bug report
> on qemu-devel recently which is fixed by these enhancements, see
> http://lists.nongnu.org/archive/html/qemu-devel/2011-03/msg02109.html.
>
> Changes in v2:
>
> * The 2nd patch is new.
>
> * Patches are sorted in a different order. The first 4 patches and the
> rest are independent, so it's possible to apply parts of the series.
>
> * The endianness patch was updated to address the feedback which I received.
> I still use local functions to access physical memory - mainly because
> I want to use cpu_physical_memory_read / cpu_physical_memory_write as long
> as I am not sure whether the alignment requirements for the suggested
> open coded variant are met.
> The prefix is e100 - shorter and more up-to-date than eepro100.
> When I started this device emulation, linux still used a module called
> eepro100. Today, the only linux module is called e100. So my final goal
> is renaming all eepro100 to e100.
>
> I did not change the patch which adds padding to short received frames,
> because I'd like to keep the preprocessor statement (CONFIG_PAD_RECEIVED_FRAMES)
> as some kind of documentation (even if QEMU's network code won't be modified
> in the near future to fully support a real ethernet emulation).
>
> Kind regards,
>
> Stefan W.
>
Applied with a small tweak, thanks!
next prev parent reply other threads:[~2011-05-05 13:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-30 20:40 [Qemu-devel] [PULL v2] eepro100: Update of patch series (fixes and enhancements) Stefan Weil
2011-04-30 20:40 ` [Qemu-devel] [PATCH v2 01/10] eepro100: Avoid duplicate debug messages Stefan Weil
2011-04-30 20:40 ` [Qemu-devel] [PATCH v2 02/10] eepro100: Remove type casts which are no longer needed Stefan Weil
2011-04-30 20:40 ` [Qemu-devel] [PATCH v2 03/10] eepro100: Remove unused structure element Stefan Weil
2011-04-30 20:40 ` [Qemu-devel] [PATCH v2 04/10] eepro100: Pad received short frames Stefan Weil
2011-05-05 13:00 ` Michael S. Tsirkin
2011-05-05 16:19 ` Stefan Weil
2011-04-30 20:40 ` [Qemu-devel] [PATCH v2 05/10] eepro100: Fix endianness issues Stefan Weil
2011-04-30 20:40 ` [Qemu-devel] [PATCH v2 06/10] eepro100: Support byte/word writes to port address Stefan Weil
2011-04-30 20:40 ` [Qemu-devel] [PATCH v2 07/10] eepro100: Support byte/word writes to pointer register Stefan Weil
2011-04-30 20:40 ` [Qemu-devel] [PATCH v2 08/10] eepro100: Support byte/word read/write access to MDI control register Stefan Weil
2011-04-30 20:40 ` [Qemu-devel] [PATCH v2 09/10] eepro100: Support byte read access to general " Stefan Weil
2011-04-30 20:40 ` [Qemu-devel] [PATCH v2 10/10] eepro100: Support 32 bit read/write access to flash register Stefan Weil
2011-05-05 13:01 ` Michael S. Tsirkin [this message]
2011-05-15 12:48 ` [Qemu-devel] [PULL v2] eepro100: Update of patch series (fixes and enhancements) Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110505130112.GD30119@redhat.com \
--to=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=weil@mail.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).