From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53943) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QHyBM-0001cy-Ra for qemu-devel@nongnu.org; Thu, 05 May 2011 09:01:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QHyBL-0000mH-Mi for qemu-devel@nongnu.org; Thu, 05 May 2011 09:01:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13173) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QHyBL-0000mA-Fj for qemu-devel@nongnu.org; Thu, 05 May 2011 09:01:27 -0400 Date: Thu, 5 May 2011 16:01:12 +0300 From: "Michael S. Tsirkin" Message-ID: <20110505130112.GD30119@redhat.com> References: <1304196013-14432-1-git-send-email-weil@mail.berlios.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1304196013-14432-1-git-send-email-weil@mail.berlios.de> Subject: Re: [Qemu-devel] [PULL v2] eepro100: Update of patch series (fixes and enhancements) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: QEMU Developers On Sat, Apr 30, 2011 at 10:40:03PM +0200, Stefan Weil wrote: > Hi, > > this is the second version of a series of patches for eepro100 which mainly > fix endianness issues and enhance register access. There was a bug report > on qemu-devel recently which is fixed by these enhancements, see > http://lists.nongnu.org/archive/html/qemu-devel/2011-03/msg02109.html. > > Changes in v2: > > * The 2nd patch is new. > > * Patches are sorted in a different order. The first 4 patches and the > rest are independent, so it's possible to apply parts of the series. > > * The endianness patch was updated to address the feedback which I received. > I still use local functions to access physical memory - mainly because > I want to use cpu_physical_memory_read / cpu_physical_memory_write as long > as I am not sure whether the alignment requirements for the suggested > open coded variant are met. > The prefix is e100 - shorter and more up-to-date than eepro100. > When I started this device emulation, linux still used a module called > eepro100. Today, the only linux module is called e100. So my final goal > is renaming all eepro100 to e100. > > I did not change the patch which adds padding to short received frames, > because I'd like to keep the preprocessor statement (CONFIG_PAD_RECEIVED_FRAMES) > as some kind of documentation (even if QEMU's network code won't be modified > in the near future to fully support a real ethernet emulation). > > Kind regards, > > Stefan W. > Applied with a small tweak, thanks!