From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:36609) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QI0dn-0005au-No for qemu-devel@nongnu.org; Thu, 05 May 2011 11:39:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QI0dm-0000Hr-VH for qemu-devel@nongnu.org; Thu, 05 May 2011 11:38:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51797) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QI0dm-0000Hl-Mh for qemu-devel@nongnu.org; Thu, 05 May 2011 11:38:58 -0400 Date: Thu, 5 May 2011 18:38:44 +0300 From: "Michael S. Tsirkin" Message-ID: <20110505153844.GE1915@redhat.com> References: <20110503182039.28430.26530.stgit@s20.home> <20110503183652.28430.83897.stgit@s20.home> <20110505132106.GG30119@redhat.com> <1304605266.3081.5.camel@x201> <4DC2B4A1.6030204@redhat.com> <20110505151859.GA1915@redhat.com> <4DC2C3E4.8020509@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4DC2C3E4.8020509@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 3/3] CPUPhysMemoryClient: Batch contiguous addresses when playing catchup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jes Sorensen Cc: jan.kiszka@siemens.com, Alex Williamson , qemu-devel@nongnu.org, armbru@redhat.com On Thu, May 05, 2011 at 05:36:04PM +0200, Jes Sorensen wrote: > On 05/05/11 17:18, Michael S. Tsirkin wrote: > >> > A memory size can obviously not be bigger than the maximum physical > >> > address, so I find it really hard to see how this could overflow. > > For example, a 4G size does not fit in 32 bits. > > That is the only corner case True. > you can handle that by -1 if you like. But then all users need to be updated. Seems easier to break out of the loop easier. It's likely not a real problem, certainly not on a pc, don't know about other systems. > Jes >