From: Isaku Yamahata <yamahata@valinux.co.jp>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/7] pci: initialize ids in pci common code
Date: Fri, 6 May 2011 00:52:12 +0900 [thread overview]
Message-ID: <20110505155212.GC25173@valinux.co.jp> (raw)
In-Reply-To: <20110505124157.GA30119@redhat.com>
On Thu, May 05, 2011 at 03:41:57PM +0300, Michael S. Tsirkin wrote:
> On Fri, Apr 08, 2011 at 09:52:59PM +0900, Isaku Yamahata wrote:
> > vender id/device id... in configuration space are read-only registers
> > which are commonly defined for all pci devices.
> > So initialize them in common code and it simplifies the initialization a bit.
> > I converted some of them.
> >
> > If this is the right direction, I'll convert the remaining devices.
>
> So I agree about device vendor id and revision but not header type:
> devices ideally should supply device type (bridge or not)
> and we will fill it in correctly.
Okay, with the nextspin, I'll drop program interface and header type
and add assert for subsystem id/vendor id.
--
yamahata
prev parent reply other threads:[~2011-05-05 15:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-08 12:52 [Qemu-devel] [PATCH 0/7] pci: initialize ids in pci common code Isaku Yamahata
2011-04-08 12:53 ` [Qemu-devel] [PATCH 1/7] pci: move ids of config space into PCIDeviceInfo Isaku Yamahata
2011-05-05 12:48 ` Michael S. Tsirkin
2011-04-08 12:53 ` [Qemu-devel] [PATCH 2/7] usb-uhci: convert to PCIDEviceInfo to initialize ids Isaku Yamahata
2011-04-08 12:53 ` [Qemu-devel] [PATCH 3/7] eepro100: convert to PCIDeviceInfo " Isaku Yamahata
2011-04-08 12:53 ` [Qemu-devel] [PATCH 4/7] dec_pci: " Isaku Yamahata
2011-04-08 12:53 ` [Qemu-devel] [PATCH 5/7] apb_pci: " Isaku Yamahata
2011-04-08 12:53 ` [Qemu-devel] [PATCH 6/7] ide/piix: " Isaku Yamahata
2011-04-08 12:53 ` [Qemu-devel] [PATCH 7/7] vmware_vga.c: " Isaku Yamahata
2011-05-05 12:41 ` [Qemu-devel] [PATCH 0/7] pci: initialize ids in pci common code Michael S. Tsirkin
2011-05-05 15:52 ` Isaku Yamahata [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110505155212.GC25173@valinux.co.jp \
--to=yamahata@valinux.co.jp \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).