From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:37355) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QILix-00077L-2A for qemu-devel@nongnu.org; Fri, 06 May 2011 10:09:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QILiw-00086B-DI for qemu-devel@nongnu.org; Fri, 06 May 2011 10:09:43 -0400 Received: from mail.codesourcery.com ([38.113.113.100]:56347) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QILiw-00085f-3F for qemu-devel@nongnu.org; Fri, 06 May 2011 10:09:42 -0400 From: Paul Brook Date: Fri, 6 May 2011 15:09:36 +0100 References: <1304686095-30265-1-git-send-email-peter.maydell@linaro.org> <1304686095-30265-5-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1304686095-30265-5-git-send-email-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201105061509.37212.paul@codesourcery.com> Subject: Re: [Qemu-devel] [PATCH 4/7] target-arm: Refactor int-float conversions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , patches@linaro.org > The Neon versions of int-float conversions need their own helper routines > because they must use the "standard FPSCR" rather than the default one. > Refactor the helper functions to make it easy to add the neon versions. > While we're touching the code, move the helpers to op_helper.c so that > we can use the global env variable rather than passing it as a parameter. IMO this is going in the wrong direction. We should in aiming for less implicit accesses to cpu state, not more. Maybe better would be to explicitly pass a pointer the fp status. That way you don't even need separate VFP and NEON variants of these routines. Paul