From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Scott Wood <scottwood@freescale.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Liu Yu <yu.liu@freescale.com>, Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH 7/7] PPC: Qdev'ify e500 pci
Date: Fri, 6 May 2011 15:36:13 +0100 [thread overview]
Message-ID: <201105061536.13783.paul@codesourcery.com> (raw)
In-Reply-To: <1304683237-26177-8-git-send-email-agraf@suse.de>
> PCIBus *ppce500_pci_init(qemu_irq pci_irqs[4], target_phys_addr_t
> registers) {
> - PPCE500PCIState *controller;
> + DeviceState *dev;
> + PCIBus *b;
> + PCIHostState *h;
> + PPCE500PCIState *s;
> PCIDevice *d;
> - int index;
> static int ppce500_pci_id;
> + SysBusDevice *sb;
> +
> + dev = qdev_create(NULL, "e500-pcihost");
> + sb = sysbus_from_qdev(dev);
> + h = FROM_SYSBUS(PCIHostState, sb);
> + s = DO_UPCAST(PPCE500PCIState, pci_state, h);
> +
> + b = pci_register_bus(&s->pci_state.busdev.qdev, NULL,
No. This function should not exist. All this should be done in
e500_pcihost_initfn. Please do the qdev conversion properly.
See versatilepb.c/versatile_pci.c for an example of how this is supposed to be
done.
> + .qdev.no_user = 1,
There's no good reason for this. It indicates you did the qdev conversion
incorrectly.
Paul
next prev parent reply other threads:[~2011-05-06 14:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-06 12:00 [Qemu-devel] [PATCH 0/7] PPC: Add FSL (e500) MMU emulation v4 Alexander Graf
2011-05-06 12:00 ` [Qemu-devel] [PATCH 1/7] PPC: Make MPC8544DS obey -cpu switch Alexander Graf
2011-05-06 12:00 ` [Qemu-devel] [PATCH 2/7] PPC: Make MPC8544DS emulation work w/o KVM Alexander Graf
2011-05-06 12:00 ` [Qemu-devel] [PATCH 3/7] PPC: Add GS MSR definition Alexander Graf
2011-05-06 12:00 ` [Qemu-devel] [PATCH 4/7] PPC: Add another 64 bits to instruction feature mask Alexander Graf
2011-05-06 12:00 ` [Qemu-devel] [PATCH 5/7] PPC: Implement e500 (FSL) MMU Alexander Graf
2011-05-06 22:25 ` Scott Wood
2011-05-07 21:36 ` Alexander Graf
2011-05-09 19:27 ` Scott Wood
2011-05-09 19:36 ` Alexander Graf
2011-05-09 19:42 ` Scott Wood
2011-05-06 12:00 ` [Qemu-devel] [PATCH 6/7] PPC MPC7544DS: Use new TLB helper function Alexander Graf
2011-05-06 12:00 ` [Qemu-devel] [PATCH 7/7] PPC: Qdev'ify e500 pci Alexander Graf
2011-05-06 14:36 ` Paul Brook [this message]
2011-05-06 16:29 ` Paul Brook
-- strict thread matches above, loose matches on Subject: below --
2011-05-07 23:00 [Qemu-devel] [PATCH 0/7] PPC: Add FSL (e500) MMU emulation v5 Alexander Graf
2011-05-07 23:00 ` [Qemu-devel] [PATCH 7/7] PPC: Qdev'ify e500 pci Alexander Graf
2011-05-07 23:48 ` Paul Brook
2011-05-07 23:58 ` Alexander Graf
2011-05-08 0:01 Alexander Graf
2011-05-09 13:44 ` Paul Brook
2011-05-09 22:15 [Qemu-devel] [PATCH 0/7] PPC: Add FSL (e500) MMU emulation v6 Alexander Graf
2011-05-09 22:15 ` [Qemu-devel] [PATCH 7/7] PPC: Qdev'ify e500 pci Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201105061536.13783.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=agraf@suse.de \
--cc=edgar.iglesias@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=scottwood@freescale.com \
--cc=yu.liu@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).