From: Scott Wood <scottwood@freescale.com>
To: Alexander Graf <agraf@suse.de>
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Liu Yu <yu.liu@freescale.com>,
QEMU-devel Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 5/7] PPC: Implement e500 (FSL) MMU
Date: Fri, 6 May 2011 17:25:32 -0500 [thread overview]
Message-ID: <20110506172532.6f03cd81@schlenkerla.am.freescale.net> (raw)
In-Reply-To: <1304683237-26177-6-git-send-email-agraf@suse.de>
On Fri, 6 May 2011 14:00:35 +0200
Alexander Graf <agraf@suse.de> wrote:
> +static inline void booke206_flush_tlb_one(ppc_tlb_t *tlb, int num)
> +{
> + int i;
> +
> + for (i = 0; i < num; i++) {
> + if ((tlb[i].tlbe.prot & PAGE_VALID) &&
> + !(tlb[i].tlbe.attr & MAS1_IPROT)) {
> + tlb[i].tlbe.prot = 0;
> + }
> + }
> +}
When this is called on reset, we want to ignore IPROT.
The valid check seems unnecessary.
> +void helper_booke206_tlbsx(target_ulong address_hi, target_ulong address_lo)
What is address_hi?
From gen_tlbsx_booke206() it looks like these two arguments correspond to
the two operands, so shouldn't they be added together? I only see
address_lo used.
-Scott
next prev parent reply other threads:[~2011-05-06 22:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-06 12:00 [Qemu-devel] [PATCH 0/7] PPC: Add FSL (e500) MMU emulation v4 Alexander Graf
2011-05-06 12:00 ` [Qemu-devel] [PATCH 1/7] PPC: Make MPC8544DS obey -cpu switch Alexander Graf
2011-05-06 12:00 ` [Qemu-devel] [PATCH 2/7] PPC: Make MPC8544DS emulation work w/o KVM Alexander Graf
2011-05-06 12:00 ` [Qemu-devel] [PATCH 3/7] PPC: Add GS MSR definition Alexander Graf
2011-05-06 12:00 ` [Qemu-devel] [PATCH 4/7] PPC: Add another 64 bits to instruction feature mask Alexander Graf
2011-05-06 12:00 ` [Qemu-devel] [PATCH 5/7] PPC: Implement e500 (FSL) MMU Alexander Graf
2011-05-06 22:25 ` Scott Wood [this message]
2011-05-07 21:36 ` Alexander Graf
2011-05-09 19:27 ` Scott Wood
2011-05-09 19:36 ` Alexander Graf
2011-05-09 19:42 ` Scott Wood
2011-05-06 12:00 ` [Qemu-devel] [PATCH 6/7] PPC MPC7544DS: Use new TLB helper function Alexander Graf
2011-05-06 12:00 ` [Qemu-devel] [PATCH 7/7] PPC: Qdev'ify e500 pci Alexander Graf
2011-05-06 14:36 ` Paul Brook
2011-05-06 16:29 ` Paul Brook
-- strict thread matches above, loose matches on Subject: below --
2011-05-07 23:00 [Qemu-devel] [PATCH 0/7] PPC: Add FSL (e500) MMU emulation v5 Alexander Graf
2011-05-07 23:00 ` [Qemu-devel] [PATCH 5/7] PPC: Implement e500 (FSL) MMU Alexander Graf
2011-05-09 22:15 [Qemu-devel] [PATCH 0/7] PPC: Add FSL (e500) MMU emulation v6 Alexander Graf
2011-05-09 22:15 ` [Qemu-devel] [PATCH 5/7] PPC: Implement e500 (FSL) MMU Alexander Graf
2011-05-20 19:10 ` Andreas Färber
2011-05-20 20:24 ` Alexander Graf
2011-05-20 21:40 ` Andreas Färber
2011-05-21 2:00 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110506172532.6f03cd81@schlenkerla.am.freescale.net \
--to=scottwood@freescale.com \
--cc=agraf@suse.de \
--cc=edgar.iglesias@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=yu.liu@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).