From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Scott Wood <scottwood@freescale.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Liu Yu <yu.liu@freescale.com>, Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH 7/7] PPC: Qdev'ify e500 pci
Date: Sun, 8 May 2011 00:48:33 +0100 [thread overview]
Message-ID: <201105080048.34812.paul@codesourcery.com> (raw)
In-Reply-To: <1304809245-7503-8-git-send-email-agraf@suse.de>
> @@ -250,7 +254,6 @@ static const VMStateDescription vmstate_ppce500_pci = {
>
> .minimum_version_id = 1,
> .minimum_version_id_old = 1,
> .fields = (VMStateField[]) {
>
> - VMSTATE_PCI_DEVICE_POINTER(pci_dev, PPCE500PCIState),
Doesn't this require incrementing version_id?
> + vmstate_register(&dev->qdev, ppce500_pci_id++, &vmstate_ppce500_pci,
ppce500_pci_id is bogus, and should be removed.
You probably shouldn't be calling this at all. Instead use
sysbus_register_withprop and qdev.vmsd.
Other than that, this patch looks ok.
Paul
next prev parent reply other threads:[~2011-05-07 23:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-07 23:00 [Qemu-devel] [PATCH 0/7] PPC: Add FSL (e500) MMU emulation v5 Alexander Graf
2011-05-07 23:00 ` [Qemu-devel] [PATCH 1/7] PPC: Make MPC8544DS obey -cpu switch Alexander Graf
2011-05-07 23:00 ` [Qemu-devel] [PATCH 2/7] PPC: Make MPC8544DS emulation work w/o KVM Alexander Graf
2011-05-08 10:08 ` Blue Swirl
2011-05-08 13:42 ` Alexander Graf
2011-05-07 23:00 ` [Qemu-devel] [PATCH 3/7] PPC: Add GS MSR definition Alexander Graf
2011-05-07 23:00 ` [Qemu-devel] [PATCH 4/7] PPC: Add another 64 bits to instruction feature mask Alexander Graf
2011-05-07 23:00 ` [Qemu-devel] [PATCH 5/7] PPC: Implement e500 (FSL) MMU Alexander Graf
2011-05-07 23:00 ` [Qemu-devel] [PATCH 6/7] PPC MPC7544DS: Use new TLB helper function Alexander Graf
2011-05-07 23:00 ` [Qemu-devel] [PATCH 7/7] PPC: Qdev'ify e500 pci Alexander Graf
2011-05-07 23:48 ` Paul Brook [this message]
2011-05-07 23:58 ` Alexander Graf
-- strict thread matches above, loose matches on Subject: below --
2011-05-09 22:15 [Qemu-devel] [PATCH 0/7] PPC: Add FSL (e500) MMU emulation v6 Alexander Graf
2011-05-09 22:15 ` [Qemu-devel] [PATCH 7/7] PPC: Qdev'ify e500 pci Alexander Graf
2011-05-08 0:01 Alexander Graf
2011-05-09 13:44 ` Paul Brook
2011-05-06 12:00 [Qemu-devel] [PATCH 0/7] PPC: Add FSL (e500) MMU emulation v4 Alexander Graf
2011-05-06 12:00 ` [Qemu-devel] [PATCH 7/7] PPC: Qdev'ify e500 pci Alexander Graf
2011-05-06 14:36 ` Paul Brook
2011-05-06 16:29 ` Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201105080048.34812.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=agraf@suse.de \
--cc=edgar.iglesias@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=scottwood@freescale.com \
--cc=yu.liu@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).