From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:55620)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paul@codesourcery.com>) id 1QIrEm-0004S7-Kc
	for qemu-devel@nongnu.org; Sat, 07 May 2011 19:48:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paul@codesourcery.com>) id 1QIrEl-0005dv-Q0
	for qemu-devel@nongnu.org; Sat, 07 May 2011 19:48:40 -0400
Received: from mail.codesourcery.com ([38.113.113.100]:48057)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paul@codesourcery.com>) id 1QIrEl-0005dZ-FE
	for qemu-devel@nongnu.org; Sat, 07 May 2011 19:48:39 -0400
From: Paul Brook <paul@codesourcery.com>
Date: Sun, 8 May 2011 00:48:33 +0100
References: <1304809245-7503-1-git-send-email-agraf@suse.de>
	<1304809245-7503-8-git-send-email-agraf@suse.de>
In-Reply-To: <1304809245-7503-8-git-send-email-agraf@suse.de>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201105080048.34812.paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 7/7] PPC: Qdev'ify e500 pci
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Scott Wood <scottwood@freescale.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Liu Yu <yu.liu@freescale.com>, Alexander Graf <agraf@suse.de>

> @@ -250,7 +254,6 @@ static const VMStateDescription vmstate_ppce500_pci = {
> 
>      .minimum_version_id = 1,
>      .minimum_version_id_old = 1,
>      .fields      = (VMStateField[]) {
> 
> -        VMSTATE_PCI_DEVICE_POINTER(pci_dev, PPCE500PCIState),

Doesn't this require incrementing version_id?

> +    vmstate_register(&dev->qdev, ppce500_pci_id++, &vmstate_ppce500_pci,

ppce500_pci_id is bogus, and should be removed.
You probably shouldn't be calling this at all.  Instead use 
sysbus_register_withprop and qdev.vmsd.

Other than that, this patch looks ok.

Paul