qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: Mathieu Sonet <contact@elasticsheep.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Add AACI audio playback support to the ARM Versatile/PB platform
Date: Thu, 12 May 2011 18:41:32 +0100	[thread overview]
Message-ID: <201105121841.33091.paul@codesourcery.com> (raw)
In-Reply-To: <4DCAD212.7090601@elasticsheep.com>

> On the other hand the current ac97.c implementation is a closely coupled
> combination of a PCI/ACLink bridge (Intel 82801AA) with a generic AC97
> codec. This has prevent me to easily reuse this code.
> 
> The milkymist-ac97 implementation is another case. It looks like a basic
> implementation with the AC97 registers directly mapped on the system bus.
> 
> Using the ACLink bus I defined, it could be interesting to implement
> separately the PCI/ACLink bridge from ac97.c.
> 
> Is it what you mean by saying this should be shared with the other AC97
> devices ?

Yes. The whole point of AClink is that it separates the host bridge from the 
codec. We now have at least three devices implementing this.  Your aclink 
implementation is only used by one of these, which gives me little confidence 
it actually does what it claims.

Paul

  reply	other threads:[~2011-05-12 17:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-10 23:13 [Qemu-devel] [PATCH] Add AACI audio playback support to the ARM Versatile/PB platform Mathieu Sonet
2011-05-10 23:25 ` malc
2011-05-11  9:58 ` Paul Brook
2011-05-11 18:14   ` Mathieu Sonet
2011-05-12 17:41     ` Paul Brook [this message]
2011-05-12 21:00       ` Mathieu Sonet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201105121841.33091.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=contact@elasticsheep.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).