From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:56434)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paul@codesourcery.com>) id 1QKZtL-000533-LQ
	for qemu-devel@nongnu.org; Thu, 12 May 2011 13:41:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paul@codesourcery.com>) id 1QKZtK-0000Lw-Me
	for qemu-devel@nongnu.org; Thu, 12 May 2011 13:41:39 -0400
Received: from mail.codesourcery.com ([38.113.113.100]:44916)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paul@codesourcery.com>) id 1QKZtK-0000L1-8V
	for qemu-devel@nongnu.org; Thu, 12 May 2011 13:41:38 -0400
From: Paul Brook <paul@codesourcery.com>
Date: Thu, 12 May 2011 18:41:32 +0100
References: <1305069201-15961-1-git-send-email-contact@elasticsheep.com>
	<201105111058.33682.paul@codesourcery.com>
	<4DCAD212.7090601@elasticsheep.com>
In-Reply-To: <4DCAD212.7090601@elasticsheep.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201105121841.33091.paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] Add AACI audio playback support to the ARM
	Versatile/PB platform
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mathieu Sonet <contact@elasticsheep.com>
Cc: qemu-devel@nongnu.org

> On the other hand the current ac97.c implementation is a closely coupled
> combination of a PCI/ACLink bridge (Intel 82801AA) with a generic AC97
> codec. This has prevent me to easily reuse this code.
> 
> The milkymist-ac97 implementation is another case. It looks like a basic
> implementation with the AC97 registers directly mapped on the system bus.
> 
> Using the ACLink bus I defined, it could be interesting to implement
> separately the PCI/ACLink bridge from ac97.c.
> 
> Is it what you mean by saying this should be shared with the other AC97
> devices ?

Yes. The whole point of AClink is that it separates the host bridge from the 
codec. We now have at least three devices implementing this.  Your aclink 
implementation is only used by one of these, which gives me little confidence 
it actually does what it claims.

Paul