From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:33614)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1QLYgK-0004t5-TF
	for qemu-devel@nongnu.org; Sun, 15 May 2011 06:36:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1QLYgJ-0002mX-Q9
	for qemu-devel@nongnu.org; Sun, 15 May 2011 06:36:16 -0400
Received: from hall.aurel32.net ([88.191.126.93]:53075)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1QLYgJ-0002mP-Jq
	for qemu-devel@nongnu.org; Sun, 15 May 2011 06:36:15 -0400
Date: Sun, 15 May 2011 12:36:12 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20110515103612.GA7778@volta.aurel32.net>
References: <1305452284-32003-1-git-send-email-weil@mail.berlios.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <1305452284-32003-1-git-send-email-weil@mail.berlios.de>
Subject: Re: [Qemu-devel] [PATCH] w32: Fix compilation and replace
 non-portable usage of ulong
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: qemu-devel@nongnu.org

On Sun, May 15, 2011 at 11:38:04AM +0200, Stefan Weil wrote:
> ulong is undefined for w32 (and maybe other) compilations.
> Replace it by uintptr_t (which also fixes compilation for w64
> and is a better choice for pointer to integer conversions).
> 
> Cc: Aurelien Jarno <aurelien@aurel32.net>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
>  target-ppc/cpu.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>
 
> diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h
> index 7a6a7df..8e4582f 100644
> --- a/target-ppc/cpu.h
> +++ b/target-ppc/cpu.h
> @@ -1929,8 +1929,8 @@ static inline void cpu_set_tls(CPUState *env, target_ulong newtls)
>  #if !defined(CONFIG_USER_ONLY)
>  static inline int booke206_tlbe_id(CPUState *env, ppcemb_tlb_t *tlbe)
>  {
> -    ulong tlbel = (ulong)tlbe;
> -    ulong tlbl = (ulong)env->tlb;
> +    uintptr_t tlbel = (uintptr_t)tlbe;
> +    uintptr_t tlbl = (uintptr_t)env->tlb;
>  
>      return (tlbel - tlbl) / sizeof(env->tlb[0]);
>  }
> -- 
> 1.5.6.5
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net